Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: standardize go mod vendor #4539

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR standardizes our usage of the vendor directory so that both the aks-engine code itself and the E2E go module store local dependencies in vendor/.

Also ships a GitHub Action to regularly maintain go mod vendor, and it replaces the (now no longer needed) hack/tools GitHub Action.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis jackfrancis merged commit 94d847e into Azure:master Jun 29, 2021
@jackfrancis jackfrancis deleted the standardize-vendor branch June 29, 2021 00:01
@acs-bot
Copy link

acs-bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants