This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: Add windowssecuretls.ps1 #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbelHu
requested review from
jackfrancis,
jadarsie and
Michael-Sinz
as code owners
8 tasks
AbelHu
force-pushed
the
abelch/add-tls-in-windows-staging-files
branch
from
ad7ca75
to
d0b4595
Compare
jsturtevant
previously approved these changes
Jul 7, 2021
|
@marosset @jackfrancis for a second review |
marosset
reviewed
Jul 7, 2021
marosset
reviewed
Jul 7, 2021
marosset
reviewed
Jul 7, 2021
marosset
reviewed
Jul 7, 2021
marosset
reviewed
Jul 7, 2021
marosset
previously approved these changes
Jul 8, 2021
There was a problem hiding this comment.
LGTM
I have one open question about mentioning TLSSetting.ps1 in the script comments but everything else looks good.
@jackfrancis @jsturtevant do either of you have opinions here?
|
@marosset I agree that mentioning a filename that isn't present in this repo, with no reference to a public URL is misleading |
AbelHu
force-pushed
the
abelch/add-tls-in-windows-staging-files
branch
from
a00e7a3
to
c9eb6b8
Compare
|
Rebase to the master |
AbelHu
force-pushed
the
abelch/add-tls-in-windows-staging-files
branch
from
c9eb6b8
to
3cfb40e
Compare
marosset
approved these changes
Jul 13, 2021
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsturtevant
approved these changes
Jul 13, 2021
|
@jackfrancis could you take alook at this? It looks like my second approval isn't enough.
|
8 tasks
jackfrancis
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add windowssecuretls.ps1 in Windows provisioning package.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: