Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: support only latest, tested versions of Kubernetes #4265

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR removes one version from each minor release from the supported versions list for Azure public cloud. In practice this means the following:

  • aks-engine will only support patch version (the most recent to be validated) of Kubernetes per minor release; for example, for 1.17, the most recent, known-working version will be supported, and no other 1.17 patch releases will be supported
  • because we only currently test one patch version per minor release (again, the most recently known-working one), this has the effect of improving the test fidelity across Kubernetes versions

This PR makes no changes to the Azure Stack Hub versions configuration, because in practice Azure Stack Hub already only supports one patch version per minor release.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4265 (57c3e60) into master (3497425) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4265      +/-   ##
==========================================
- Coverage   72.07%   72.06%   -0.01%     
==========================================
  Files         141      141              
  Lines       21686    21686              
==========================================
- Hits        15630    15628       -2     
- Misses       5106     5107       +1     
- Partials      950      951       +1     
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
cmd/get_versions.go 89.47% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3497425...57c3e60. Read the comment docs.

@jadarsie
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 1de0ab8 into Azure:master Feb 12, 2021
@jackfrancis jackfrancis deleted the versions-support-latest-patch-version branch February 12, 2021 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants