From ca11c189698a31aec44527af53dfc0572f60796d Mon Sep 17 00:00:00 2001
From: Jan Mach <janmach1@microsoft.com>
Date: Thu, 11 Apr 2024 15:00:28 +0200
Subject: [PATCH] API Dropdown - navigation fix

---
 .../apis/list-of-apis/ko/runtime/api-list-dropdown.html       | 4 ++--
 .../apis/list-of-apis/ko/runtime/api-list-dropdown.ts         | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.html b/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.html
index 89f4ab281..34328a345 100644
--- a/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.html
+++ b/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.html
@@ -49,7 +49,7 @@
                 <div class="menu menu-vertical" role="list">
                     <!-- ko foreach: { data: group.items, as: 'item' } -->
                     <a href="#" role="listitem" class="nav-link text-truncate" data-dismiss
-                        data-bind="attr: { href: $component.getReferenceUrl(item) }, css: { 'nav-link-active': $component.selectedApiName() === item.name }, activate: $component.closeDropdown">
+                        data-bind="attr: { href: $component.getReferenceUrl(item) }, css: { 'nav-link-active': $component.selectedApiName() === item.name }, click: $component.closeDropdown">
                         <span data-bind="text: item.displayName"></span>
                         <!-- ko if: item.type === 'soap' -->
                         <span class="badge badge-soap">SOAP</span>
@@ -79,7 +79,7 @@
             <!-- ko foreach: { data: apis, as: 'item' } -->
             <div class="menu menu-vertical" role="list">
                 <a href="#" role="listitem" class="nav-link text-truncate" data-dismiss
-                    data-bind="attr: { href: $component.getReferenceUrl(item) }, css: { 'nav-link-active': $component.selectedApiName() === item.name }, activate: $component.closeDropdown">
+                    data-bind="attr: { href: $component.getReferenceUrl(item) }, css: { 'nav-link-active': $component.selectedApiName() === item.name }, click: $component.closeDropdown">
                     <span data-bind="text: item.displayName"></span>
                     <!-- ko if: item.type === 'soap' -->
                     <span class="badge badge-soap">SOAP</span>
diff --git a/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.ts b/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.ts
index f537b6535..ac21f8182 100644
--- a/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.ts
+++ b/src/components/apis/list-of-apis/ko/runtime/api-list-dropdown.ts
@@ -184,12 +184,14 @@ export class ApiListDropdown {
         this.groupTagsExpanded(newSet);
     }
 
-    public closeDropdown(): void {
+    public closeDropdown(): true {
         const apiDropdowns = document.getElementsByClassName("api-list-dropdown");
         for (let i = 0; i < apiDropdowns.length; i++) {
             if (apiDropdowns[i].classList.contains("show"))
                 apiDropdowns[i].classList.remove("show");
         }
+
+        return true; // return true to not-prevent the default action https://knockoutjs.com/documentation/click-binding.html#note-3-allowing-the-default-click-action
     }
 
     @OnDestroyed()