From 398de91ca58b1b7e7f5d26d5ae3d6a1025e6126f Mon Sep 17 00:00:00 2001
From: Igor O <ygrik@hotmail.com>
Date: Tue, 19 Nov 2024 16:50:10 -0800
Subject: [PATCH] Fixed tooltip button position Fixed scrolling on subscription
 rename/cancel

---
 .../apis/details-of-api/ko/detailsOfApiEditor.html          | 4 ++--
 src/components/apis/list-of-apis/ko/listOfApisEditor.html   | 6 +++---
 .../validation-summary/ko/runtime/validation-summary.ts     | 2 +-
 src/themes/designer/styles/forms.scss                       | 4 ++++
 4 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/components/apis/details-of-api/ko/detailsOfApiEditor.html b/src/components/apis/details-of-api/ko/detailsOfApiEditor.html
index b41c3c225..05a0c5a6a 100644
--- a/src/components/apis/details-of-api/ko/detailsOfApiEditor.html
+++ b/src/components/apis/details-of-api/ko/detailsOfApiEditor.html
@@ -3,9 +3,9 @@
         <div class="label-group">
             <label for="hyperlink" class="form-label">
                 Link to API changelog page
+                <button class="btn btn-info" type="button" title="Help" aria-label="Help"
+                    data-bind="tooltip: 'A link to be navigated on click.'"></button>
             </label>
-            <button class="btn btn-info" type="button" title="Help" aria-label="Help"
-                data-bind="tooltip: 'A link to be navigated on click.'"></button>
         </div>
         <div class="input-group">
             <input id="hyperlink" type="text" class="form-control" disabled data-bind="value: hyperlinkTitle" />
diff --git a/src/components/apis/list-of-apis/ko/listOfApisEditor.html b/src/components/apis/list-of-apis/ko/listOfApisEditor.html
index 5fcfde75f..3dda98b03 100644
--- a/src/components/apis/list-of-apis/ko/listOfApisEditor.html
+++ b/src/components/apis/list-of-apis/ko/listOfApisEditor.html
@@ -24,10 +24,10 @@
         <div class="label-group">
             <label for="hyperlink" class="form-label">
                 Link to API details page
+                <button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
+                    aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
+                </button>
             </label>
-            <button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
-                aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
-            </button>
         </div>
         <div class="input-group">
             <input type="text" id="hyperlink" class="form-control" disabled data-bind="value: hyperlinkTitle" />
diff --git a/src/components/users/validation-summary/ko/runtime/validation-summary.ts b/src/components/users/validation-summary/ko/runtime/validation-summary.ts
index 8c426c532..6f1a585a4 100644
--- a/src/components/users/validation-summary/ko/runtime/validation-summary.ts
+++ b/src/components/users/validation-summary/ko/runtime/validation-summary.ts
@@ -40,10 +40,10 @@ export class ValidationSummary {
         this.errorMsgs(errorSum);
         if (this.errorMsgs().length > 0) {
             this.hasErrors(true);
+            document.getElementsByTagName(selector)[0]?.scrollIntoView();
         } else {
             this.hasErrors(false);
         }
 
-        document.getElementsByTagName(selector)[0]?.scrollIntoView();
     }
 }
diff --git a/src/themes/designer/styles/forms.scss b/src/themes/designer/styles/forms.scss
index da0c32f2c..9ac61443c 100644
--- a/src/themes/designer/styles/forms.scss
+++ b/src/themes/designer/styles/forms.scss
@@ -22,6 +22,10 @@
         margin-bottom: 15px;
     }
 
+    label.form-label {
+        position: relative;
+    }
+
     &.form-group-collapsible {
         & > .form-label {
             position: unset;