{Service Connector} Add input validation for run_cli_cmd
#29798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Service Connector |
yungezz
approved these changes
Aug 28, 2024
|
Please use our centralized function |
AllyW
reviewed
Aug 28, 2024
src/azure-cli/azure/cli/command_modules/serviceconnector/_transformers.py
Show resolved
Hide resolved
AllyW
reviewed
Aug 28, 2024
src/azure-cli/azure/cli/command_modules/serviceconnector/_transformers.py
Show resolved
Hide resolved
AllyW
reviewed
Aug 28, 2024
xfz11
changed the title
|
@AllyW Could you help review and merge the PR? |
For input validation from business logic, please involve related team members to review and confirm it first. |
brycechen1849
approved these changes
Sep 3, 2024
|
Proper input validation is necessary for reducing command risks, but for |
AllyW
approved these changes
Sep 3, 2024
AllyW
changed the title
run_cli_cmd
kairu-ms
approved these changes
Sep 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.