Skip to content

Commit

Permalink
Code changes to address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
@kundadebdatta
kundadebdatta committed Aug 30, 2022
1 parent 2469f31 commit 575681b
Showing 1 changed file with 58 additions and 46 deletions.
104 changes: 58 additions & 46 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PartitionKeyRangeCacheTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,23 @@ public void Initialize()
/// Test to validate that when a fresh container is created, TryGetOverlappingRangesAsync() should not
/// add same key to the trace dictionary. The same key could be regenerated, if the CPU computation is
/// fast enough to invoke TryLookupAsync within .5 to 15 ms timeframe, which may lead to get the exact
/// same UTC DateTime, which is nothing but the trace key.
/// same UTC DateTime, which is nothing but the trace key. An example trace JSON with the PKRange Info
/// nodes can be found below:
///
/// "name": "Try Get Overlapping Ranges",
/// "id": "9d28a8cb-9669-422b-9619-b91cbbf61dff",
/// "start time": "06:16:03:990",
/// "duration in milliseconds": 50.8808,
/// "data": {
/// "PKRangeCache Info(#2022-08-30T18:16:04.0364155Z)": {
/// "Previous Continuation Token": null,
/// "Continuation Token": "483"
/// },
/// "PKRangeCache Info(483#2022-08-30T18:16:04.0394322Z)": {
/// "Previous Continuation Token": "483",
/// "Continuation Token": "483"
/// }
/// },
/// </summary>
/// <returns>
/// A <see cref="Task"/> object indicating the test is finished.
Expand All @@ -59,61 +75,57 @@ public async Task TryGetOverlappingRangesAsync_WithFreshContainer_ShouldNotAddSa
string containerRId = "kjhsAA==";
string singlePkCollectionCache = "{\"_rid\":\"3FIlAOzjvyg=\",\"PartitionKeyRanges\":[{\"_rid\":\"3FIlAOzjvygCAAAAAAAAUA==\",\"id\":\"0\",\"_etag\":\"\\\"00005565-0000-0800-0000-621fd98a0000\\\"\",\"minInclusive\":\"\",\"maxExclusive\":\"FF\",\"ridPrefix\":0,\"_self\":\"dbs/3FIlAA==/colls/3FIlAOzjvyg=/pkranges/3FIlAOzjvygCAAAAAAAAUA==/\",\"throughputFraction\":1,\"status\":\"splitting\",\"parents\":[],\"_ts\":1646254474,\"_lsn\":44}],\"_count\":1}";
byte[] singlePkCollectionCacheByte = Encoding.UTF8.GetBytes(singlePkCollectionCache);
ITrace trace = Trace.GetRootTrace(this.TestContext.TestName, TraceComponent.Unknown, TraceLevel.Info);

Mock<IStoreModel> mockStoreModel = new();
Mock<CollectionCache> mockCollectioNCache = new();
Mock<ICosmosAuthorizationTokenProvider> mockTokenProvider = new();
NameValueCollectionWrapper headers = new()
using (ITrace trace = Trace.GetRootTrace(this.TestContext.TestName, TraceComponent.Unknown, TraceLevel.Info))
{
[HttpConstants.HttpHeaders.ETag] = eTag,
};

mockStoreModel.SetupSequence(x => x.ProcessMessageAsync(It.IsAny<DocumentServiceRequest>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(new DocumentServiceResponse(new MemoryStream(singlePkCollectionCacheByte),
new StoreResponseNameValueCollection()
{
ETag = eTag,
},
HttpStatusCode.OK))
.ReturnsAsync(new DocumentServiceResponse(null, headers, HttpStatusCode.NotModified, null))
.ReturnsAsync(new DocumentServiceResponse(null, headers, HttpStatusCode.NotModified, null));
Mock<IStoreModel> mockStoreModel = new();
Mock<CollectionCache> mockCollectioNCache = new();
Mock<ICosmosAuthorizationTokenProvider> mockTokenProvider = new();
NameValueCollectionWrapper headers = new()
{
[HttpConstants.HttpHeaders.ETag] = eTag,
};

mockTokenProvider.Setup(x => x.GetUserAuthorizationTokenAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<INameValueCollection>(), It.IsAny<AuthorizationTokenType>(), It.IsAny<ITrace>()))
.Returns(new ValueTask<string>(authToken));
mockStoreModel.SetupSequence(x => x.ProcessMessageAsync(It.IsAny<DocumentServiceRequest>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(new DocumentServiceResponse(new MemoryStream(singlePkCollectionCacheByte),
new StoreResponseNameValueCollection()
{
ETag = eTag,
},
HttpStatusCode.OK))
.ReturnsAsync(new DocumentServiceResponse(null, headers, HttpStatusCode.NotModified, null))
.ReturnsAsync(new DocumentServiceResponse(null, headers, HttpStatusCode.NotModified, null));

// Act.
PartitionKeyRangeCache partitionKeyRangeCache = new (mockTokenProvider.Object, mockStoreModel.Object, mockCollectioNCache.Object);
IReadOnlyList<PartitionKeyRange> partitionKeyRanges = await partitionKeyRangeCache.TryGetOverlappingRangesAsync(
containerRId,
FeedRangeEpk.FullRange.Range,
trace,
forceRefresh: true);
mockTokenProvider.Setup(x => x.GetUserAuthorizationTokenAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<INameValueCollection>(), It.IsAny<AuthorizationTokenType>(), It.IsAny<ITrace>()))
.Returns(new ValueTask<string>(authToken));

// Assert.
string dataPath = "children[0].data", previousContinuationTokenKey = "['Previous Continuation Token']", diagnostics = new CosmosTraceDiagnostics(trace).ToString();
JObject traceData = JsonConvert.DeserializeObject<JObject>(diagnostics);
// Act.
PartitionKeyRangeCache partitionKeyRangeCache = new(mockTokenProvider.Object, mockStoreModel.Object, mockCollectioNCache.Object);
IReadOnlyList<PartitionKeyRange> partitionKeyRanges = await partitionKeyRangeCache.TryGetOverlappingRangesAsync(
containerRId,
FeedRangeEpk.FullRange.Range,
trace,
forceRefresh: true);

Assert.IsNotNull(traceData);
// Assert.
string dataPath = "children[0].data", previousContinuationTokenKey = "['Previous Continuation Token']", diagnostics = new CosmosTraceDiagnostics(trace).ToString();
JObject traceData = JsonConvert.DeserializeObject<JObject>(diagnostics);

string firstPkRangeCacheKeyName = ((JProperty)traceData.SelectToken(dataPath)?.First).Name;
string secondPkRangeCacheKeyName = ((JProperty)traceData.SelectToken(dataPath)?.Last).Name;
Assert.IsNotNull(traceData);

Assert.IsNotNull(firstPkRangeCacheKeyName);
Assert.IsNotNull(secondPkRangeCacheKeyName);
Assert.IsTrue(firstPkRangeCacheKeyName.Length > 0);
Assert.IsTrue(secondPkRangeCacheKeyName.Length > 0);
Assert.AreNotEqual(firstPkRangeCacheKeyName, secondPkRangeCacheKeyName);
string firstPkRangeCacheKeyName = ((JProperty)traceData.SelectToken(dataPath)?.First).Name;
string secondPkRangeCacheKeyName = ((JProperty)traceData.SelectToken(dataPath)?.Last).Name;

string firstPkRangeValue = ((JProperty)traceData.SelectToken(dataPath).First)?.Value?.SelectToken(previousContinuationTokenKey)?.ToString();
string secondPkRangeValue = ((JProperty)traceData.SelectToken(dataPath).Last)?.Value?.SelectToken(previousContinuationTokenKey)?.ToString();
Assert.IsTrue(!string.IsNullOrWhiteSpace(firstPkRangeCacheKeyName));
Assert.IsTrue(!string.IsNullOrWhiteSpace(secondPkRangeCacheKeyName));
Assert.AreNotEqual(firstPkRangeCacheKeyName, secondPkRangeCacheKeyName);

Assert.IsNotNull(firstPkRangeValue);
Assert.IsNotNull(secondPkRangeValue);
Assert.IsTrue(firstPkRangeValue.Length == 0);
Assert.AreEqual(eTag, secondPkRangeValue);
string firstPkRangeValue = ((JProperty)traceData.SelectToken(dataPath).First)?.Value?.SelectToken(previousContinuationTokenKey)?.ToString();
string secondPkRangeValue = ((JProperty)traceData.SelectToken(dataPath).Last)?.Value?.SelectToken(previousContinuationTokenKey)?.ToString();

trace.Dispose();
Assert.IsTrue(!string.IsNullOrWhiteSpace(secondPkRangeValue));
Assert.IsTrue(string.IsNullOrEmpty(firstPkRangeValue));
Assert.AreEqual(eTag, secondPkRangeValue);
}
}
}
}

0 comments on commit 575681b

Please sign in to comment.