remove dispose from sampler

Azure · Mar 15, 2023 · ce3467c · ce3467c
1 parent d1a8c35
commit ce3467c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/ClientTelemetry.cs b/Microsoft.Azure.Cosmos/src/Telemetry/ClientTelemetry.cs
@@ -352,7 +352,7 @@ internal void CollectOperationInfo(CosmosDiagnostics cosmosDiagnostics,
  /// <param name="droppedRntbdRequestCount"></param>
  private void RecordRntbdResponses(string containerId, string databaseId, List<StoreResponseStatistics> storeResponseStatistics, out int droppedRntbdRequestCount)
  {
- using IClientTelemetrySampler<RequestInfo> networkRequestSampler 
+ IClientTelemetrySampler<RequestInfo> networkRequestSampler 
  = new NetworkRequestSampler(ClientTelemetryOptions.NetworkTelemetrySampleSize);
 
  droppedRntbdRequestCount = 0;

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/Sampler/IClientTelemetrySampler.cs b/Microsoft.Azure.Cosmos/src/Telemetry/Sampler/IClientTelemetrySampler.cs
@@ -6,7 +6,7 @@ namespace Microsoft.Azure.Cosmos.Telemetry.Sampler
 {
  using System;
 
- internal interface IClientTelemetrySampler<T> : IDisposable
+ internal interface IClientTelemetrySampler<T>
  {
  internal bool ShouldSample(T statisticsObj);
  }

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/Sampler/NetworkRequestSampler.cs b/Microsoft.Azure.Cosmos/src/Telemetry/Sampler/NetworkRequestSampler.cs
@@ -66,10 +66,5 @@ private static bool IsStatusCodeNotExcluded(int statusCode, int subStatusCode)
  {
  return !(ClientTelemetryOptions.ExcludedStatusCodes.Contains(statusCode) && subStatusCode == 0);
  }
-
- public void Dispose()
- {
- this.TempStorage.Clear();
- }
  }
 }