Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics: Log ApplicationRegion in ClientConfiguration trace #3198

Closed
abhijitpai opened this issue May 17, 2022 · 1 comment · Fixed by #3202
Closed

Diagnostics: Log ApplicationRegion in ClientConfiguration trace #3198

abhijitpai opened this issue May 17, 2022 · 1 comment · Fixed by #3202
Assignees
@imanvt
Labels
Diagnostics Issues around diagnostics and troubleshooting

Comments

@abhijitpai
Copy link
Contributor

abhijitpai commented May 17, 2022 •
edited
Loading

Log ApplicationRegion in ClientConfiguration trace to help debugging. We currently log preferred regions in the diagnostics trace only when ApplicationPreferredRegions is set.
@j82w j82w added the Diagnostics Issues around diagnostics and troubleshooting label May 17, 2022
@j82w j82w assigned imanvt and unassigned j82w May 17, 2022
@j82w
Copy link
Contributor

j82w commented May 17, 2022

The diagnostics log only the preferred region. It should also log application region.
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Tracing/TraceData/ConsistencyConfig.cs#L27

@imanvt imanvt mentioned this issue May 18, 2022
Merged
@imanvt imanvt linked a pull request May 18, 2022 that will close this issue
Diagnostics: Adds Application region into Client Configuration Trace #3202
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imanvt imanvt

Labels
Diagnostics Issues around diagnostics and troubleshooting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diagnostics: Adds Application region into Client Configuration Trace Azure/azure-cosmos-dotnet-v3
3 participants
@j82w @abhijitpai @imanvt