From 3207ab543a2036e6a994bc27ba6ec4401cecac89 Mon Sep 17 00:00:00 2001 From: Jake Willey Date: Wed, 2 Sep 2020 07:17:52 -0700 Subject: [PATCH] Make request options properties public --- .../src/RequestOptions/RequestOptions.cs | 9 ++------ .../Contracts/DotNetPreviewSDKAPI.json | 22 +------------------ .../Contracts/DotNetSDKAPI.json | 19 ++++++++++++++++ 3 files changed, 22 insertions(+), 28 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/RequestOptions/RequestOptions.cs b/Microsoft.Azure.Cosmos/src/RequestOptions/RequestOptions.cs index fc9e26d871..ab06eb81b7 100644 --- a/Microsoft.Azure.Cosmos/src/RequestOptions/RequestOptions.cs +++ b/Microsoft.Azure.Cosmos/src/RequestOptions/RequestOptions.cs @@ -31,15 +31,10 @@ public class RequestOptions public string IfNoneMatchEtag { get; set; } /// - /// Application opted Cosmos request conext that flow through with the . + /// Application opted Cosmos request context that flow through with the . /// Context will be available through handlers. /// -#if PREVIEW - public -#else - internal -#endif - IReadOnlyDictionary Properties { get; set; } + public IReadOnlyDictionary Properties { get; set; } /// /// Gets or sets the boolean to use effective partition key routing in the cosmos db request. diff --git a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json index e8131410f3..4ba6d19b34 100644 --- a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json +++ b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json @@ -275,27 +275,7 @@ "NestedTypes": {} } }, - "Members": { - "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": { - "Type": "Method", - "Attributes": [ - "CompilerGeneratedAttribute" - ], - "MethodInfo": "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()" - }, - "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] Properties": { - "Type": "Property", - "Attributes": [], - "MethodInfo": null - }, - "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": { - "Type": "Method", - "Attributes": [ - "CompilerGeneratedAttribute" - ], - "MethodInfo": "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])" - } - }, + "Members": {}, "NestedTypes": {} } }, diff --git a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json index 1383774c5a..210b1ae2d1 100644 --- a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json +++ b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json @@ -5362,6 +5362,18 @@ } }, "Members": { + "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": { + "Type": "Method", + "Attributes": [ + "CompilerGeneratedAttribute" + ], + "MethodInfo": "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()" + }, + "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] Properties": { + "Type": "Property", + "Attributes": [], + "MethodInfo": null + }, "System.String get_IfMatchEtag()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": { "Type": "Method", "Attributes": [ @@ -5404,6 +5416,13 @@ "CompilerGeneratedAttribute" ], "MethodInfo": "Void set_IfNoneMatchEtag(System.String)" + }, + "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": { + "Type": "Method", + "Attributes": [ + "CompilerGeneratedAttribute" + ], + "MethodInfo": "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])" } }, "NestedTypes": {}