Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Adds Transport Layer Header Improvements #3078

Conversation

asketagarwal
Copy link
Contributor

Draft PR for master repo that changes the way SDK lookups header from the INameValueCollection

@asketagarwal asketagarwal changed the title DRAFT: Transport Layer Header Improvements DRAFT: Adds Transport Layer Header Improvements Mar 14, 2022
@asketagarwal asketagarwal marked this pull request as draft March 14, 2022 14:51
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@github-actions github-actions bot dismissed their stale review March 14, 2022 14:52

All good!

TransportSerialization.FillTokenFromHeader(request, HttpConstants.HttpHeaders.IsClientEncrypted, rntbdRequest.isClientEncrypted, rntbdRequest);
TransportSerialization.FillTokenFromHeader(request, WFConstants.BackendHeaders.CorrelatedActivityId, rntbdRequest.correlatedActivityId, rntbdRequest);
*/
internal interface IRequestHeaders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IStoreRequestHeaders

@@ -15,7 +15,7 @@ namespace Microsoft.Azure.Cosmos
using Microsoft.Azure.Documents;
using Microsoft.Azure.Documents.Collections;

internal class StoreRequestNameValueCollection : CosmosMessageHeadersInternal, INameValueCollection
internal class StoreRequestNameValueCollection : CosmosMessageHeadersInternal, INameValueCollection, IRequestHeaders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j82w
Copy link
Contributor

j82w commented May 6, 2022

Moved: #3177

@j82w j82w closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants