[Internal] Distributed Tracing: Fixes Client Config Test #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
philipthomas-MSFT
approved these changes
Apr 11, 2024
NaluTripician
approved these changes
Apr 11, 2024
kirankumarkolli
approved these changes
Apr 12, 2024
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/dtbugfix
branch
sourabh1007
added a commit
that referenced
this pull request
Apr 12, 2024
* Adds code to create activity even customer is not subscribed to the feature * Added documentation
sourabh1007
added a commit
that referenced
this pull request
Apr 12, 2024
* Adds code to create activity even customer is not subscribed to the feature * Added documentation
sourabh1007
added a commit
that referenced
this pull request
Apr 15, 2024
* Adds code to create activity even customer is not subscribed to the feature * Added documentation
sourabh1007
added a commit
that referenced
this pull request
Apr 15, 2024
* Adds code to create activity even customer is not subscribed to the feature * Added documentation
This was referenced Apr 15, 2024
sourabh1007
added a commit
that referenced
this pull request
Apr 15, 2024
* Adds code to create activity even customer is not subscribed to the feature * Added documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the change?
Added "back", logic to generate activity id, even if customer is not subscribed to any source.
Why is change required?
As part of PR #4333, I removed network level traces generation, along with that, this code was also removed where we were making sure that traceid is generated, even if customer is not subscribed to the any traces.
Why was it not caught in PR pipelines?
It is part of emulator test, and we don't run emulator test in "preview" mode, in our PR pipelines.
Type of change
Closing issues
This would unblock 3.39.0 release