Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default eventhubs batchsize is incorrect #1629

Closed
paulbatum opened this issue Jun 27, 2017 · 2 comments
Closed

Default eventhubs batchsize is incorrect #1629

paulbatum opened this issue Jun 27, 2017 · 2 comments
Assignees
@paulbatum
Labels
bug
Milestone
Backlog

Comments

@paulbatum
Copy link
Member

paulbatum commented Jun 27, 2017 •
edited
Loading

The default batchsize for eventhubs in Azure Functions is supposed to match the defaults that were changed in webjobs in this commit. However in practice these defaults are not honored. This results in the default batchsize being passed to event hub as 1000, and I think that then converts into 300 somehow (might be related to prefetch).

The configuration code needs to be fixed to allow the defaults specified by webjobs to take effect unless the user overrides them.
@paulbatum paulbatum added the bug label Jun 27, 2017
@paulbatum paulbatum added this to the Sprint 1 milestone Jun 27, 2017
@paulbatum paulbatum self-assigned this Jun 27, 2017
@paulbatum paulbatum modified the milestones: Sprint 2, Sprint 1 Jul 12, 2017
@paulbatum paulbatum modified the milestones: Sprint 2, Sprint 5 Aug 9, 2017
@paulbatum paulbatum modified the milestones: Sprint 5, Sprint 7 Sep 20, 2017
@paulbatum paulbatum modified the milestones: Sprint 7, Next Oct 4, 2017
@paulbatum paulbatum mentioned this issue Apr 26, 2018
Merged
paulbatum added a commit to paulbatum/azure-functions-host that referenced this issue May 1, 2018
@paulbatum
Fix Azure#1629 - default event hubs batch size is incorrect
85d9b60 
It looks like when the event hubs extension was updated to the new model to parse host.json, the same code in the script layer was not removed, causing this issue. Added tests and also verified manually that this fix works.
paulbatum added a commit that referenced this issue May 1, 2018
@paulbatum
Fix #1629 - default event hubs batch size is incorrect
4850cc1 
It looks like when the event hubs extension was updated to the new model to parse host.json, the same code in the script layer was not removed, causing this issue. Added tests and also verified manually that this fix works.
@mathewc
Copy link
Member

mathewc commented Jun 29, 2018

@paulbatum can this issue be closed?

@paulbatum
Copy link
Member Author

Yes.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulbatum paulbatum

Labels
bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@paulbatum @mathewc