From 7c33857fb196d29acdeef1f05c7865706bcb96cc Mon Sep 17 00:00:00 2001 From: Mathew Charles Date: Fri, 4 May 2018 10:38:03 -0700 Subject: [PATCH] Change Blobs.CentralizedPoisonQueue default (#1106) --- .../Binding/WebJobsCoreScriptBindingProvider.cs | 2 -- test/WebJobs.Script.Tests/ScriptHostTests.cs | 6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/WebJobs.Script/Binding/WebJobsCoreScriptBindingProvider.cs b/src/WebJobs.Script/Binding/WebJobsCoreScriptBindingProvider.cs index fb1fc84728..07676c8c29 100644 --- a/src/WebJobs.Script/Binding/WebJobsCoreScriptBindingProvider.cs +++ b/src/WebJobs.Script/Binding/WebJobsCoreScriptBindingProvider.cs @@ -26,8 +26,6 @@ public WebJobsCoreScriptBindingProvider(JobHostConfiguration config, JObject hos public override void Initialize() { // Apply Blobs configuration - // TODO: FACAVAL - Follow up on TEMP comment below - Config.Blobs.CentralizedPoisonQueue = true; // TEMP : In the next release we'll remove this and accept the core SDK default var configSection = (JObject)Metadata["blobs"]; JToken value = null; if (configSection != null) diff --git a/test/WebJobs.Script.Tests/ScriptHostTests.cs b/test/WebJobs.Script.Tests/ScriptHostTests.cs index 741dbbd796..a34076e060 100644 --- a/test/WebJobs.Script.Tests/ScriptHostTests.cs +++ b/test/WebJobs.Script.Tests/ScriptHostTests.cs @@ -577,14 +577,14 @@ public void ApplyConfiguration_Blobs() WebJobsCoreScriptBindingProvider provider = new WebJobsCoreScriptBindingProvider(hostConfig, config, null); provider.Initialize(); - Assert.True(hostConfig.Blobs.CentralizedPoisonQueue); + Assert.False(hostConfig.Blobs.CentralizedPoisonQueue); - blobsConfig["centralizedPoisonQueue"] = false; + blobsConfig["centralizedPoisonQueue"] = true; provider = new WebJobsCoreScriptBindingProvider(hostConfig, config, null); provider.Initialize(); - Assert.False(hostConfig.Blobs.CentralizedPoisonQueue); + Assert.True(hostConfig.Blobs.CentralizedPoisonQueue); } [Fact]