Do not send null or empty values #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
approved these changes
Oct 22, 2019
|
Wouldn’t nodejs worker throw an error when trying to set empty value for an environment variable? |
|
@pragnagopa - the error is a buffer overrun that messes up the payload in deserializing the gRPC message, so no error from nodejs worker code :\ and sadly are no errors when this overrun behavior is happening: Azure/azure-functions-language-worker-protobuf#21. |
fabiocav
pushed a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4488
Once this is deployed, we should resolve issue #5115