Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure IoT Hub list persists over DPS enrollment (group) updates #701

Merged
merged 4 commits into from
May 23, 2024

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented May 21, 2024

With respect to Azure/azure-cli#29002

Fixing some weirdness in DPS enrollments and enrollment groups:

  1. fix the iot hub param to allow multiple uses

create a new enrollment group with 2 iot hubs (here I just use the same one):
image

  1. ensure that update will keep the iot hub list unless a new list is given

re-use the enrollment; update the allocation policy and see that the hubs are still there:
image

try to update to static, get expected failure because there are 2 hubs:
image

get it to work when a single hub is defined:
image

  1. minimize the number of inputs needed to update custom allocation policy enrollments

going from static to custom, all inputs are still needed:
image

image

only want to update the url:
image

tests
image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@vilit1 vilit1 requested a review from digimaun as a code owner May 21, 2024 23:27
@vilit1 vilit1 merged commit 57a9f85 into Azure:dev May 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants