Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Repurpose ADO release pipeline as integration testing pipeline #703

Merged
merged 25 commits into from
Jun 6, 2024

Conversation

c-ryan-k
Copy link
Member

@c-ryan-k c-ryan-k commented Jun 4, 2024

This converts our legacy ADO release pipeline into a hefty integration test pipeline.

This is triggered now as part of our release workflow, github actions will queue and track the ADO build in our pipeline.

It is not required to complete in order to draft the release, so we can review flaky tests or re-run tests if needed:
image

Since this pipeline is no longer building a release candidate artifact, there's no need for 1ES runner images, or the release stage.

An example pipeline can be found here: https://github.com/c-ryan-k/azure-iot-cli-extension/actions/runs/9373681178


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@c-ryan-k c-ryan-k marked this pull request as ready for review June 6, 2024 01:21
@c-ryan-k c-ryan-k requested a review from digimaun as a code owner June 6, 2024 01:21
@c-ryan-k c-ryan-k requested review from vilit1 and removed request for digimaun June 6, 2024 01:22
@c-ryan-k c-ryan-k requested a review from digimaun June 6, 2024 16:21
@c-ryan-k c-ryan-k merged commit a49151f into Azure:dev Jun 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants