From f4bf405ead62cafecb3a704d1cd2a3587db79003 Mon Sep 17 00:00:00 2001 From: Azad Abbasi Date: Tue, 11 Jan 2022 16:33:14 -0800 Subject: [PATCH 1/4] Update IDeviceIdentity interface to add doc comments. --- .../device/src/Transport/IDeviceIdentity.cs | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/iothub/device/src/Transport/IDeviceIdentity.cs b/iothub/device/src/Transport/IDeviceIdentity.cs index f03e181959..523056a542 100644 --- a/iothub/device/src/Transport/IDeviceIdentity.cs +++ b/iothub/device/src/Transport/IDeviceIdentity.cs @@ -3,15 +3,44 @@ namespace Microsoft.Azure.Devices.Client.Transport { + /// + /// Interface for device configurations and common attributes. + /// internal interface IDeviceIdentity { + /// + /// Authentication model for the device. + /// AuthenticationModel AuthenticationModel { get; } + + /// + /// AMQP transport layer settings of the device. + /// AmqpTransportSettings AmqpTransportSettings { get; } + + /// + /// Device connection string details. + /// IotHubConnectionString IotHubConnectionString { get; } + + /// + /// Device details and information. + /// ProductInfo ProductInfo { get; } + + /// + /// Device configuration options at the time of initialization. + /// ClientOptions Options { get; } + + /// + /// Device authentication audience. + /// string Audience { get; } + /// + /// Whether or not Device is part of a connection pooling. + /// bool IsPooling(); } } From 70c6970fb0c3f014ae3ef250d94afdc1df0c52af Mon Sep 17 00:00:00 2001 From: Azad Abbasi Date: Wed, 12 Jan 2022 13:39:33 -0800 Subject: [PATCH 2/4] Move DeviceIdentity and its interface to AMQP namespace. --- iothub/device/src/Transport/{ => Amqp}/DeviceIdentity.cs | 2 +- iothub/device/src/Transport/{ => Amqp}/IDeviceIdentity.cs | 2 +- iothub/device/src/Transport/AmqpIot/AmqpIotSession.cs | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) rename iothub/device/src/Transport/{ => Amqp}/DeviceIdentity.cs (98%) rename iothub/device/src/Transport/{ => Amqp}/IDeviceIdentity.cs (95%) diff --git a/iothub/device/src/Transport/DeviceIdentity.cs b/iothub/device/src/Transport/Amqp/DeviceIdentity.cs similarity index 98% rename from iothub/device/src/Transport/DeviceIdentity.cs rename to iothub/device/src/Transport/Amqp/DeviceIdentity.cs index 6b13877ca4..8689ac3111 100644 --- a/iothub/device/src/Transport/DeviceIdentity.cs +++ b/iothub/device/src/Transport/Amqp/DeviceIdentity.cs @@ -4,7 +4,7 @@ using System.Net; using Microsoft.Azure.Devices.Client.Extensions; -namespace Microsoft.Azure.Devices.Client.Transport +namespace Microsoft.Azure.Devices.Client.Transport.Amqp { /// /// Device configurations diff --git a/iothub/device/src/Transport/IDeviceIdentity.cs b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs similarity index 95% rename from iothub/device/src/Transport/IDeviceIdentity.cs rename to iothub/device/src/Transport/Amqp/IDeviceIdentity.cs index 523056a542..3927819413 100644 --- a/iothub/device/src/Transport/IDeviceIdentity.cs +++ b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs @@ -1,7 +1,7 @@ // Copyright (c) Microsoft. All rights reserved. // Licensed under the MIT license. See LICENSE file in the project root for full license information. -namespace Microsoft.Azure.Devices.Client.Transport +namespace Microsoft.Azure.Devices.Client.Transport.Amqp { /// /// Interface for device configurations and common attributes. diff --git a/iothub/device/src/Transport/AmqpIot/AmqpIotSession.cs b/iothub/device/src/Transport/AmqpIot/AmqpIotSession.cs index e03bfa93bc..b9c8eeb805 100644 --- a/iothub/device/src/Transport/AmqpIot/AmqpIotSession.cs +++ b/iothub/device/src/Transport/AmqpIot/AmqpIotSession.cs @@ -10,6 +10,7 @@ using Microsoft.Azure.Amqp.Framing; using Microsoft.Azure.Devices.Client.Exceptions; using Microsoft.Azure.Devices.Client.Extensions; +using Microsoft.Azure.Devices.Client.Transport.Amqp; using Microsoft.Azure.Devices.Shared; namespace Microsoft.Azure.Devices.Client.Transport.AmqpIot From 2798f86ca5a8918c9f069b3e871c6b3d0d0f4929 Mon Sep 17 00:00:00 2001 From: Azad Abbasi Date: Thu, 13 Jan 2022 10:05:47 -0800 Subject: [PATCH 3/4] Update IDeviceIdentity.cs --- iothub/device/src/Transport/Amqp/IDeviceIdentity.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs index 3927819413..3966a7c740 100644 --- a/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs +++ b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs @@ -24,7 +24,7 @@ internal interface IDeviceIdentity IotHubConnectionString IotHubConnectionString { get; } /// - /// Device details and information. + /// SDK,.NET version, Operating system and environment information. /// ProductInfo ProductInfo { get; } From 3890f7d4df6eb2142898f7df8dd8b1667fd89013 Mon Sep 17 00:00:00 2001 From: Azad Abbasi Date: Thu, 13 Jan 2022 10:06:31 -0800 Subject: [PATCH 4/4] Update IDeviceIdentity.cs --- iothub/device/src/Transport/Amqp/IDeviceIdentity.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs index 3966a7c740..e459aed554 100644 --- a/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs +++ b/iothub/device/src/Transport/Amqp/IDeviceIdentity.cs @@ -39,7 +39,7 @@ internal interface IDeviceIdentity string Audience { get; } /// - /// Whether or not Device is part of a connection pooling. + /// Whether or not the device is part of a connection pooling. /// bool IsPooling(); }