From 1b4ddfaa4820c15e0c0992e0959c857149c0a045 Mon Sep 17 00:00:00 2001
From: Elie Abi Chahine <elabicha@microsoft.com>
Date: Sat, 6 Feb 2021 22:15:54 -0800
Subject: [PATCH 1/4] Adding tagValue and tagKey to ReportConfigFilter
---
.../stable/2019-11-01/costmanagement.json | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
index 23e92ac1d302..4f8cf1ea6047 100644
--- a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
+++ b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
@@ -1487,6 +1487,14 @@
"tags": {
"description": "Has comparison expression for a tag",
"$ref": "#/definitions/ReportConfigComparisonExpression"
+ },
+ "tagValue": {
+ "description": "Has comparison expression for a tag value",
+ "$ref": "#/definitions/ReportConfigComparisonExpression"
+ },
+ "tagKey": {
+ "description": "Has comparison expression for a tag key",
+ "$ref": "#/definitions/ReportConfigComparisonExpression"
}
}
},
From d9e0eca8393bce3337b2e2162287d2b677190f98 Mon Sep 17 00:00:00 2001
From: Elie Abi Chahine <elabicha@microsoft.com>
Date: Sun, 7 Feb 2021 21:53:40 -0800
Subject: [PATCH 2/4] remove the addition of tagValue
---
.../stable/2019-11-01/costmanagement.json | 4 ----
1 file changed, 4 deletions(-)
diff --git a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
index 4f8cf1ea6047..dfbc94d54ee4 100644
--- a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
+++ b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
@@ -1488,10 +1488,6 @@
"description": "Has comparison expression for a tag",
"$ref": "#/definitions/ReportConfigComparisonExpression"
},
- "tagValue": {
- "description": "Has comparison expression for a tag value",
- "$ref": "#/definitions/ReportConfigComparisonExpression"
- },
"tagKey": {
"description": "Has comparison expression for a tag key",
"$ref": "#/definitions/ReportConfigComparisonExpression"
From fc3e45cad8e5cb92dfdf87fe9f9cda72820035b9 Mon Sep 17 00:00:00 2001
From: Elie Abi Chahine <elabicha@microsoft.com>
Date: Wed, 17 Feb 2021 21:48:34 -0800
Subject: [PATCH 3/4] Adding TagValue in the config filter
---
.../stable/2019-11-01/costmanagement.json | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
index dfbc94d54ee4..cbb591ffd933 100644
--- a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
+++ b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
@@ -1491,6 +1491,10 @@
"tagKey": {
"description": "Has comparison expression for a tag key",
"$ref": "#/definitions/ReportConfigComparisonExpression"
+ },
+ "tagValue": {
+ "description": "Has comparison expression for a tag value",
+ "$ref": "#/definitions/ReportConfigComparisonExpression"
}
}
},
From de293beb356e90c07f3eba228beb3b8b0bb99499 Mon Sep 17 00:00:00 2001
From: Elie Abi Chahine <elabicha@microsoft.com>
Date: Fri, 26 Feb 2021 23:59:22 -0800
Subject: [PATCH 4/4] make filter name property nullable
---
.../stable/2019-11-01/costmanagement.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
index 8a62002e0d69..609162e99b4c 100644
--- a/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
+++ b/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
@@ -1518,7 +1518,8 @@
"properties": {
"name": {
"description": "The name of the column to use in comparison.",
- "type": "string"
+ "type": "string",
+ "x-nullable": true
},
"operator": {
"description": "The operator to use for comparison.",