Adding x-ms-ids for Application Insights #17590

agalerrotaru · 2022-02-01T21:15:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-01T21:15:41Z

Hi, @agalerrotaru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2022-02-01T21:15:42Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-workflow-bot · 2022-02-01T21:15:42Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-01T21:15:42Z

Swagger pipeline can not start as the pull request has merge conflicts.

ghost · 2022-02-01T21:15:43Z

Thank you for your contribution agalerrotaru! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2022-02-01T21:16:30Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:Microsoft.Insights/stable/2015-05-01 compared with base:Microsoft.Insights/stable/2015-05-01
- current:stable/2020-02-02/components_API.json compared with base:stable/2020-02-02/components_API.json
- current:stable/2020-11-20/workbookTemplates_API.json compared with base:stable/2020-11-20/workbookTemplates_API.json
- current:stable/2021-03-08/workbookOperations_API.json compared with base:stable/2021-03-08/workbookOperations_API.json
- current:stable/2021-10-14/livetoken_API.json compared with base:stable/2021-10-14/livetoken_API.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/providers/microsoft.insights/operations' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/generatelivetoken' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L77
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/providers/microsoft.insights/operations' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/generatelivetoken' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L77
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
`❌` R3020 - PathResourceProviderNamePascalCase	Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
`❌` R3026 - TrackedResourcePatchOperation	Tracked resource 'Workbook' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L473
`❌` R3026 - TrackedResourcePatchOperation	Tracked resource 'Workbook' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L473
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L77
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-01-11

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json#L322
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json#L322

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️❌CredScan: 0 Errors, 0 Warnings failed [Detail]

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-01T21:16:31Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armapplicationinsights - 0.3.0

❌azure-sdk-for-go - appinsights/mgmt/2020-02-02/insights - v61.4.0

+	Const `ItemTypeFolder` has been removed

❌azure-sdk-for-go - appinsights/mgmt/2015-05-01/insights - v61.4.0

+	Const `Folder` has been removed

️✔️azure-sdk-for-go - preview/appinsights/mgmt/2022-01-11-preview/insights - v61.4.0
❌azure-sdk-for-go - preview/appinsights/mgmt/2021-11-01-preview/insights - v61.4.0

+	Const `ItemTypeFolder` has been removed

❌azure-sdk-for-go - preview/appinsights/mgmt/2020-02-02-preview/insights - v61.4.0

+	Package was removed

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-applicationinsights - 2.1.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.ApplicationInsights [View full logs] [Release SDK Changes]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.3` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-applicationinsights [View full logs] [Release SDK Changes]
- azure-mgmt-applicationinsights-2.1.0.zip
- azure_mgmt_applicationinsights-2.1.0-py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-03-07 06:49:23 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-applicationinsights;1.0.0-beta.3;1.0.0-beta.4"
cmderr	[generate.py] 2022-03-07 06:49:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.4"
cmderr	[generate.py] 2022-03-07 06:49:23 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/applicationinsights/azure-resourcemanager-applicationinsights --java.namespace=com.azure.resourcemanager.applicationinsights   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-applicationinsights
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Skip] pom already has module azure-resourcemanager-applicationinsights
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Skip] pom already has module sdk/applicationinsights
cmderr	[generate.py] 2022-03-07 06:49:59 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-applicationinsights [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-03-07 06:50:57 DEBUG Got artifact_id: azure-resourcemanager-applicationinsights
cmderr	[Inst] 2022-03-07 06:50:57 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-03-07 06:50:57 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.4.jar
cmderr	[Inst] 2022-03-07 06:50:57 DEBUG Match jar package: azure-resourcemanager-applicationinsights-1.0.0-beta.4.jar
cmderr	[Inst] 2022-03-07 06:50:57 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17590/azure-sdk-for-java/azure-resourcemanager-applicationinsights/azure-resourcemanager-applicationinsights-1.0.0-beta.4.jar\" -o azure-resourcemanager-applicationinsights-1.0.0-beta.4.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-applicationinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-applicationinsights-1.0.0-beta.4.jar -Dpackaging=jar -DgeneratePom=true
```"}

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation] [AUTOREST] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[generator automation] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/aiOperations_API.json:114:8 ($.definitions.OperationListResult.properties.value)
cmderr	[generator automation] [AUTOREST] FATAL: swagger-document/individual/schema-validator - FAILED
cmderr	[generator automation] [AUTOREST] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmderr	[generator automation] [AUTOREST] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
cmderr	[generator automation] [ERROR] total 1 error(s):
cmderr	[generator automation] [ERROR] failed to execute autorest: autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.187, --go, --verbose, --go-sdk-folder=., --use-onever, --version=V2, --go.license-header=MICROSOFT_MIT_NO_VERSION, --pass-thru:schema-validator-swagger, --enum-prefix, --tag=package-2022-01-11, --metadata-output-folder=/home/vsts/work/1/s/azure-sdk-for-go_tmp/generation-metadata-1646635834/package-2022-01-11, ../../../../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md':
cmderr	[generator automation] [ERROR] exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armapplicationinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `WorkbookTemplateLocalizedGallery.TemplateData` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Type of `WorkbookTemplateProperties.TemplateData` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Function `OperationsListResult.MarshalJSON` has been removed
info	[Changelog] - Function `NewOperationsClient` has been removed
info	[Changelog] - Function `*OperationsClientListPager.NextPage` has been removed
info	[Changelog] - Function `*OperationsClientListPager.PageResponse` has been removed
info	[Changelog] - Function `WorkbookInnerErrorTrace.MarshalJSON` has been removed
info	[Changelog] - Function `WorkbookTemplateErrorBody.MarshalJSON` has been removed
info	[Changelog] - Function `*OperationsClient.List` has been removed
info	[Changelog] - Function `InnerError.MarshalJSON` has been removed
info	[Changelog] - Function `InnerErrorTrace.MarshalJSON` has been removed
info	[Changelog] - Function `*InnerError.UnmarshalJSON` has been removed
info	[Changelog] - Function `OperationListResult.MarshalJSON` has been removed
info	[Changelog] - Function `*OperationsClientListPager.Err` has been removed
info	[Changelog] - Struct `AnnotationError` has been removed
info	[Changelog] - Struct `ErrorDefinition` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog] - Struct `ErrorResponseLinkedStorage` has been removed
info	[Changelog] - Struct `ErrorResponseLinkedStorageError` has been removed
info	[Changelog] - Struct `InnerError` has been removed
info	[Changelog] - Struct `InnerErrorTrace` has been removed
info	[Changelog] - Struct `MyWorkbookError` has been removed
info	[Changelog] - Struct `Operation` has been removed
info	[Changelog] - Struct `OperationDisplay` has been removed
info	[Changelog] - Struct `OperationInfo` has been removed
info	[Changelog] - Struct `OperationListResult` has been removed
info	[Changelog] - Struct `OperationLive` has been removed
info	[Changelog] - Struct `OperationsClient` has been removed
info	[Changelog] - Struct `OperationsClientListOptions` has been removed
info	[Changelog] - Struct `OperationsClientListPager` has been removed
info	[Changelog] - Struct `OperationsClientListResponse` has been removed
info	[Changelog] - Struct `OperationsClientListResult` has been removed
info	[Changelog] - Struct `OperationsListResult` has been removed
info	[Changelog] - Struct `WorkItemConfigurationError` has been removed
info	[Changelog] - Struct `WorkbookError` has been removed
info	[Changelog] - Struct `WorkbookErrorDefinition` has been removed
info	[Changelog] - Struct `WorkbookInnerErrorTrace` has been removed
info	[Changelog] - Struct `WorkbookTemplateError` has been removed
info	[Changelog] - Struct `WorkbookTemplateErrorBody` has been removed
info	[Changelog] - Struct `WorkbookTemplateErrorFieldContract` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Etag` in struct `Component`
info	[Changelog] - New field `DisableLocalAuth` in struct `ComponentProperties`
info	[Changelog] - New field `ForceCustomerStorageForProfiler` in struct `ComponentProperties`
info	[Changelog] - New field `LaMigrationDate` in struct `ComponentProperties`
info	[Changelog] - New field `WorkspaceResourceID` in struct `ComponentProperties`
info	[Changelog] - New field `Name` in struct `ComponentProperties`
info	[Changelog]
info	[Changelog] Total 66 breaking change(s), 2 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 9735d8c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appinsights [View full logs] [Release SDK Changes]
- azure-arm-appinsights-5.0.0-beta.3.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 9735d8c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️applicationinsights [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-01T21:19:04Z

Hi @agalerrotaru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

agalerrotaru · 2022-02-08T18:19:21Z

@JoshLove-msft I see you were a contributor to app insights. Can you advise on the breaking change and model validation errors that are unrelated to my changes in this PR?

ArcturusZhang · 2022-02-09T02:28:03Z

The breakign changes in track 2 Go SDK are introduced by recent changes of go code generator. I approved them all.

ArcturusZhang · 2022-02-09T02:28:25Z

/azp run

azure-pipelines · 2022-02-09T02:28:36Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2022-02-09T02:29:10Z

The failure in azure-sdk-for-go has been fixed in the pipelines, after a rerun it should pass.

agalerrotaru · 2022-02-09T19:21:39Z

/azp run

azure-pipelines · 2022-02-09T19:21:44Z

Commenter does not have sufficient privileges for PR 17590 in repo Azure/azure-rest-api-specs

akning-ms · 2022-02-10T07:27:12Z

@raych1 to check why Modal validation fail as seems it is not related with this PR

raych1 · 2022-02-10T09:56:10Z

@raych1 to check why Modal validation fail as seems it is not related with this PR

invalid_type issues are real issues in examples but are not caused by this PR changes.

ghost · 2022-02-27T16:04:06Z

Hi, @agalerrotaru. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

* Adding x-ms-ids for Application Insights * Corrections from rebasing

Adding x-ms-ids for Application Insights

f71cbeb

openapi-assignment-bot bot assigned akning-ms Feb 1, 2022

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 1, 2022

Merge branch 'main' into agalerrotaru/applicationinsights

d3159c2

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 1, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 1, 2022

agalerrotaru and others added 2 commits February 2, 2022 14:23

Merge branch 'Azure:main' into agalerrotaru/applicationinsights

6c43d6c

Corrections from rebasing

281ec26

ArcturusZhang added the Approved-SdkBreakingChange-Go-V2 label Feb 9, 2022

openapi-sdkautomation bot mentioned this pull request Feb 9, 2022

[AutoPR track2_@azure/arm-appinsights] Adding x-ms-ids for Application Insights AzureSDKAutomation/azure-sdk-for-js#7470

Draft

agalerrotaru closed this Feb 9, 2022

agalerrotaru reopened this Feb 9, 2022

agalerrotaru closed this Feb 9, 2022

agalerrotaru reopened this Feb 9, 2022

ghost added the no-recent-activity label Feb 27, 2022

akning-ms added the Approved-ModelValidation label Mar 7, 2022

ghost removed the no-recent-activity label Mar 7, 2022

akning-ms approved these changes Mar 7, 2022

View reviewed changes

akning-ms merged commit 9735d8c into Azure:main Mar 7, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

Adding x-ms-ids for Application Insights (Azure#17590)

e1e100d

* Adding x-ms-ids for Application Insights * Corrections from rebasing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding x-ms-ids for Application Insights #17590

Adding x-ms-ids for Application Insights #17590

agalerrotaru commented Feb 1, 2022 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022

openapi-workflow-bot bot commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022

ghost commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 1, 2022

agalerrotaru commented Feb 8, 2022

ArcturusZhang commented Feb 9, 2022

ArcturusZhang commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

ArcturusZhang commented Feb 9, 2022

agalerrotaru commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

akning-ms commented Feb 10, 2022

raych1 commented Feb 10, 2022 •

edited

Loading

ghost commented Feb 27, 2022

Adding x-ms-ids for Application Insights #17590

Adding x-ms-ids for Application Insights #17590

Conversation

agalerrotaru commented Feb 1, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022

openapi-workflow-bot bot commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022

ghost commented Feb 1, 2022

openapi-pipeline-app bot commented Feb 1, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 1, 2022

agalerrotaru commented Feb 8, 2022

ArcturusZhang commented Feb 9, 2022

ArcturusZhang commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

ArcturusZhang commented Feb 9, 2022

agalerrotaru commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

akning-ms commented Feb 10, 2022

raych1 commented Feb 10, 2022 • edited Loading

ghost commented Feb 27, 2022

agalerrotaru commented Feb 1, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2022 •

edited

Loading

raych1 commented Feb 10, 2022 •

edited

Loading