Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'ssivathas/2023-06-01' #24528

Merged

Conversation

JeetendraJoshi-MSFT
Copy link
Contributor

@JeetendraJoshi-MSFT JeetendraJoshi-MSFT commented Jun 21, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@JeetendraJoshi-MSFT
Copy link
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12428

@openapi-workflow-bot
Copy link

Hi, @JeetendraJoshi-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 21, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 174 Errors, 180 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    attachedDataNetwork.json 2023-06-01(76bcb3f) 2022-11-01(main)
    attachedDataNetwork.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    common.json 2023-06-01(76bcb3f) 2022-11-01(main)
    common.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    dataNetwork.json 2023-06-01(76bcb3f) 2022-11-01(main)
    dataNetwork.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    mobileNetwork.json 2023-06-01(76bcb3f) 2022-11-01(main)
    mobileNetwork.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    operation.json 2023-06-01(76bcb3f) 2022-11-01(main)
    operation.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    packetCoreControlPlane.json 2023-06-01(76bcb3f) 2022-11-01(main)
    packetCoreControlPlane.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    packetCoreDataPlane.json 2023-06-01(76bcb3f) 2022-11-01(main)
    packetCoreDataPlane.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    service.json 2023-06-01(76bcb3f) 2022-11-01(main)
    service.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    sim.json 2023-06-01(76bcb3f) 2022-11-01(main)
    simGroup.json 2023-06-01(76bcb3f) 2022-11-01(main)
    simPolicy.json 2023-06-01(76bcb3f) 2022-11-01(main)
    simPolicy.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    site.json 2023-06-01(76bcb3f) 2022-11-01(main)
    slice.json 2023-06-01(76bcb3f) 2022-11-01(main)
    slice.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)
    ts29571.json 2023-06-01(76bcb3f) 2022-11-01(main)
    ts29571.json 2023-06-01(76bcb3f) 2022-04-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3
    Old: Microsoft.MobileNetwork/stable/2022-11-01/packetCoreControlPlane.json#L548:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/simGroup.json#L316:3
    Old: Microsoft.MobileNetwork/stable/2022-11-01/simGroup.json#L316:3
    1019 - RemovedEnumValue The new version is removing enum value(s) 'SystemAssigned, SystemAssigned,UserAssigned' from the old version.
    New: Microsoft.MobileNetwork/stable/2023-06-01/common.json#L536:9
    Old: common-types/resource-management/v3/managedidentity.json#L65:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'SystemAssigned, SystemAssigned,UserAssigned' from the old version.
    New: Microsoft.MobileNetwork/stable/2023-06-01/common.json#L520:5
    Old: common-types/resource-management/v3/managedidentity.json#L35:5
    1019 - RemovedEnumValue The new version is removing enum value(s) 'SystemAssigned, SystemAssigned,UserAssigned' from the old version.
    New: Microsoft.MobileNetwork/stable/2023-06-01/common.json#L536:9
    Old: common-types/resource-management/v3/managedidentity.json#L65:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'SystemAssigned, SystemAssigned,UserAssigned' from the old version.
    New: Microsoft.MobileNetwork/stable/2023-06-01/common.json#L520:5
    Old: common-types/resource-management/v3/managedidentity.json#L35:5
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/attachedDataNetwork.json#L44:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/attachedDataNetwork.json#L44:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/attachedDataNetwork.json#L97:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/attachedDataNetwork.json#L97:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/attachedDataNetwork.json#L143:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/attachedDataNetwork.json#L143:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/attachedDataNetwork.json#L208:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/attachedDataNetwork.json#L208:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/attachedDataNetwork.json#L265:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/attachedDataNetwork.json#L265:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L633:5
    Old: common-types/resource-management/v3/types.json#L622:5
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L205:9
    Old: common-types/resource-management/v3/types.json#L204:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L211:9
    Old: common-types/resource-management/v3/types.json#L209:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/dataNetwork.json#L44:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/dataNetwork.json#L44:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/dataNetwork.json#L94:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/dataNetwork.json#L94:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/dataNetwork.json#L137:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/dataNetwork.json#L137:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/dataNetwork.json#L199:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/dataNetwork.json#L199:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MobileNetwork/stable/2023-06-01/dataNetwork.json#L253:9
    Old: Microsoft.MobileNetwork/stable/2022-11-01/dataNetwork.json#L253:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L633:5
    Old: common-types/resource-management/v3/types.json#L622:5
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/types.json#L14:9
    Old: common-types/resource-management/v3/types.json#L14:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/listSimIds' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L315:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites/{siteName}' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L367:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L576:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L621:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L818:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L857:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims/{simName}' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L899:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims' removed or restructured?
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1056:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SimGroup' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SimGroupPropertiesFormat' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'KeyVaultKey' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Sim' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SimPropertiesFormat' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Site' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SitePropertiesFormat' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SimPolicyResourceId' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SimState' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'UserAssignedIdentities' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentityType' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'KeyVaultCertificate' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed?
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SimGroupNameParameter' removed or renamed?
    New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2
    Old: azure-rest-api-specs/blob/main/revision#L2960:2
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SimNameParameter' removed or renamed?
    New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2
    Old: azure-rest-api-specs/blob/main/revision#L2960:2
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SiteNameParameter' removed or renamed?
    New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2
    Old: azure-rest-api-specs/blob/main/revision#L2960:2
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'PacketCoreControlPlaneVersions_ListByResourceGroup' to 'PacketCoreControlPlaneVersions_List'. This will impact generated code.
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L512:7
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L356:7
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L1001:9
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L539:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L201:13
    Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L201:13
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-06 package-2023-06(76bcb3f) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.MobileNetwork/stable/2023-06-01/operation.json#L77
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.MobileNetwork/stable/2023-06-01/operation.json#L86
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.MobileNetwork/stable/2023-06-01/sim.json#L604
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

    Tag package-2023-06; Prod region: Not deployed; Canary region: Not deployed

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 21, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/mobilenetwork/armmobilenetwork - Approved - 3.0.0
    +	Field `PrincipalID`, `TenantID` of struct `ManagedServiceIdentity` has been removed
    +	Function `*PacketCoreControlPlanesClient.UpdateTags` parameter(s) have been changed from `(context.Context, string, string, TagsObject, *PacketCoreControlPlanesClientUpdateTagsOptions)` to `(context.Context, string, string, IdentityAndTagsObject, *PacketCoreControlPlanesClientUpdateTagsOptions)`
    +	Function `*SimGroupsClient.UpdateTags` parameter(s) have been changed from `(context.Context, string, string, TagsObject, *SimGroupsClientUpdateTagsOptions)` to `(context.Context, string, string, IdentityAndTagsObject, *SimGroupsClientUpdateTagsOptions)`
    +	Function `NewPacketCoreControlPlaneVersionsClient` parameter(s) have been changed from `(azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
    +	`BillingSKUG3`, `BillingSKUG4` from enum `BillingSKU` has been removed
    +	`ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned` from enum `ManagedServiceIdentityType` has been removed
    azure-sdk-for-js - @azure/arm-mobilenetwork - Approved - 3.0.0
    +	Class MobileNetworkManagementClient has a new signature
    +	Enum KnownBillingSku no longer has value G3
    +	Enum KnownBillingSku no longer has value G4
    +	Enum KnownManagedServiceIdentityType no longer has value SystemAssigned
    +	Enum KnownManagedServiceIdentityType no longer has value SystemAssignedUserAssigned
    +	Interface ManagedServiceIdentity no longer has parameter principalId
    +	Interface ManagedServiceIdentity no longer has parameter tenantId
    +	Operation PacketCoreControlPlanes.updateTags has a new signature
    +	Operation SimGroups.updateTags has a new signature
    azure-sdk-for-python - track2_azure-mgmt-mobilenetwork - Approved - 2.0.0
    +	Model ManagedServiceIdentity no longer has parameter principal_id
    +	Model ManagedServiceIdentity no longer has parameter tenant_id
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8cb7f0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-mobilenetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation PacketCoreControlPlaneVersionsOperations.get_by_subscription
      info	[Changelog]   - Added operation PacketCoreControlPlaneVersionsOperations.list_by_subscription
      info	[Changelog]   - Added operation SitesOperations.begin_delete_packet_core
      info	[Changelog]   - Added operation group DiagnosticsPackagesOperations
      info	[Changelog]   - Added operation group PacketCapturesOperations
      info	[Changelog]   - Model Installation has a new parameter desired_state
      info	[Changelog]   - Model Installation has a new parameter reasons
      info	[Changelog]   - Model Installation has a new parameter reinstall_required
      info	[Changelog]   - Model PacketCoreControlPlane has a new parameter diagnostics_upload
      info	[Changelog]   - Model PacketCoreControlPlane has a new parameter installed_version
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ManagedServiceIdentity no longer has parameter principal_id
      info	[Changelog]   - Model ManagedServiceIdentity no longer has parameter tenant_id
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8cb7f0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-mobilenetwork [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a8cb7f0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mobilenetwork/armmobilenetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `NewPacketCoreControlPlaneVersionsClient` parameter(s) have been changed from `(azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
      info	[Changelog] - Function `*PacketCoreControlPlanesClient.UpdateTags` parameter(s) have been changed from `(context.Context, string, string, TagsObject, *PacketCoreControlPlanesClientUpdateTagsOptions)` to `(context.Context, string, string, IdentityAndTagsObject, *PacketCoreControlPlanesClientUpdateTagsOptions)`
      info	[Changelog] - Function `*SimGroupsClient.UpdateTags` parameter(s) have been changed from `(context.Context, string, string, TagsObject, *SimGroupsClientUpdateTagsOptions)` to `(context.Context, string, string, IdentityAndTagsObject, *SimGroupsClientUpdateTagsOptions)`
      info	[Changelog] - `BillingSKUG3`, `BillingSKUG4` from enum `BillingSKU` has been removed
      info	[Changelog] - `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned` from enum `ManagedServiceIdentityType` has been removed
      info	[Changelog] - Field `PrincipalID`, `TenantID` of struct `ManagedServiceIdentity` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `CoreNetworkTypeEPC5GC` added to enum type `CoreNetworkType`
      info	[Changelog] - New enum type `DesiredInstallationState` with values `DesiredInstallationStateInstalled`, `DesiredInstallationStateUninstalled`
      info	[Changelog] - New enum type `DiagnosticsPackageStatus` with values `DiagnosticsPackageStatusCollected`, `DiagnosticsPackageStatusCollecting`, `DiagnosticsPackageStatusError`, `DiagnosticsPackageStatusNotStarted`
      info	[Changelog] - New enum type `InstallationReason` with values `InstallationReasonNoAttachedDataNetworks`, `InstallationReasonNoPacketCoreDataPlane`, `InstallationReasonNoSlices`
      info	[Changelog] - New enum type `PacketCaptureStatus` with values `PacketCaptureStatusError`, `PacketCaptureStatusNotStarted`, `PacketCaptureStatusRunning`, `PacketCaptureStatusStopped`
      info	[Changelog] - New enum type `ReinstallRequired` with values `ReinstallRequiredNotRequired`, `ReinstallRequiredRequired`
      info	[Changelog] - New function `*ClientFactory.NewDiagnosticsPackagesClient() *DiagnosticsPackagesClient`
      info	[Changelog] - New function `*ClientFactory.NewPacketCapturesClient() *PacketCapturesClient`
      info	[Changelog] - New function `NewDiagnosticsPackagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DiagnosticsPackagesClient, error)`
      info	[Changelog] - New function `*DiagnosticsPackagesClient.BeginCreateOrUpdate(context.Context, string, string, string, *DiagnosticsPackagesClientBeginCreateOrUpdateOptions) (*runtime.Poller[DiagnosticsPackagesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*DiagnosticsPackagesClient.BeginDelete(context.Context, string, string, string, *DiagnosticsPackagesClientBeginDeleteOptions) (*runtime.Poller[DiagnosticsPackagesClientDeleteResponse], error)`
      info	[Changelog] - New function `*DiagnosticsPackagesClient.Get(context.Context, string, string, string, *DiagnosticsPackagesClientGetOptions) (DiagnosticsPackagesClientGetResponse, error)`
      info	[Changelog] - New function `*DiagnosticsPackagesClient.NewListByPacketCoreControlPlanePager(string, string, *DiagnosticsPackagesClientListByPacketCoreControlPlaneOptions) *runtime.Pager[DiagnosticsPackagesClientListByPacketCoreControlPlaneResponse]`
      info	[Changelog] - New function `NewPacketCapturesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PacketCapturesClient, error)`
      info	[Changelog] - New function `*PacketCapturesClient.BeginCreateOrUpdate(context.Context, string, string, string, PacketCapture, *PacketCapturesClientBeginCreateOrUpdateOptions) (*runtime.Poller[PacketCapturesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*PacketCapturesClient.BeginDelete(context.Context, string, string, string, *PacketCapturesClientBeginDeleteOptions) (*runtime.Poller[PacketCapturesClientDeleteResponse], error)`
      info	[Changelog] - New function `*PacketCapturesClient.Get(context.Context, string, string, string, *PacketCapturesClientGetOptions) (PacketCapturesClientGetResponse, error)`
      info	[Changelog] - New function `*PacketCapturesClient.NewListByPacketCoreControlPlanePager(string, string, *PacketCapturesClientListByPacketCoreControlPlaneOptions) *runtime.Pager[PacketCapturesClientListByPacketCoreControlPlaneResponse]`
      info	[Changelog] - New function `*PacketCapturesClient.BeginStop(context.Context, string, string, string, *PacketCapturesClientBeginStopOptions) (*runtime.Poller[PacketCapturesClientStopResponse], error)`
      info	[Changelog] - New function `*PacketCoreControlPlaneVersionsClient.GetBySubscription(context.Context, string, *PacketCoreControlPlaneVersionsClientGetBySubscriptionOptions) (PacketCoreControlPlaneVersionsClientGetBySubscriptionResponse, error)`
      info	[Changelog] - New function `*PacketCoreControlPlaneVersionsClient.NewListBySubscriptionPager(*PacketCoreControlPlaneVersionsClientListBySubscriptionOptions) *runtime.Pager[PacketCoreControlPlaneVersionsClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*SitesClient.BeginDeletePacketCore(context.Context, string, string, string, SiteDeletePacketCore, *SitesClientBeginDeletePacketCoreOptions) (*runtime.Poller[SitesClientDeletePacketCoreResponse], error)`
      info	[Changelog] - New struct `DiagnosticsPackage`
      info	[Changelog] - New struct `DiagnosticsPackageListResult`
      info	[Changelog] - New struct `DiagnosticsPackagePropertiesFormat`
      info	[Changelog] - New struct `DiagnosticsUploadConfiguration`
      info	[Changelog] - New struct `IdentityAndTagsObject`
      info	[Changelog] - New struct `PacketCapture`
      info	[Changelog] - New struct `PacketCaptureListResult`
      info	[Changelog] - New struct `PacketCapturePropertiesFormat`
      info	[Changelog] - New struct `PacketCoreControlPlaneResourceID`
      info	[Changelog] - New struct `SiteDeletePacketCore`
      info	[Changelog] - New field `DesiredState`, `Reasons`, `ReinstallRequired` in struct `Installation`
      info	[Changelog] - New field `DiagnosticsUpload`, `InstalledVersion` in struct `PacketCoreControlPlanePropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 59 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a8cb7f0. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-mobilenetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group DiagnosticsPackages
      info	[Changelog]   - Added operation group PacketCaptures
      info	[Changelog]   - Added operation PacketCoreControlPlaneVersions.getBySubscription
      info	[Changelog]   - Added operation PacketCoreControlPlaneVersions.listBySubscription
      info	[Changelog]   - Added operation Sites.beginDeletePacketCore
      info	[Changelog]   - Added operation Sites.beginDeletePacketCoreAndWait
      info	[Changelog]   - Added Interface DiagnosticsPackage
      info	[Changelog]   - Added Interface DiagnosticsPackageListResult
      info	[Changelog]   - Added Interface DiagnosticsPackagesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface DiagnosticsPackagesDeleteOptionalParams
      info	[Changelog]   - Added Interface DiagnosticsPackagesGetOptionalParams
      info	[Changelog]   - Added Interface DiagnosticsPackagesListByPacketCoreControlPlaneNextOptionalParams
      info	[Changelog]   - Added Interface DiagnosticsPackagesListByPacketCoreControlPlaneOptionalParams
      info	[Changelog]   - Added Interface DiagnosticsUploadConfiguration
      info	[Changelog]   - Added Interface IdentityAndTagsObject
      info	[Changelog]   - Added Interface PacketCapture
      info	[Changelog]   - Added Interface PacketCaptureListResult
      info	[Changelog]   - Added Interface PacketCapturesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface PacketCapturesDeleteOptionalParams
      info	[Changelog]   - Added Interface PacketCapturesGetOptionalParams
      info	[Changelog]   - Added Interface PacketCapturesListByPacketCoreControlPlaneNextOptionalParams
      info	[Changelog]   - Added Interface PacketCapturesListByPacketCoreControlPlaneOptionalParams
      info	[Changelog]   - Added Interface PacketCapturesStopOptionalParams
      info	[Changelog]   - Added Interface PacketCoreControlPlaneResourceId
      info	[Changelog]   - Added Interface PacketCoreControlPlaneVersionsGetBySubscriptionOptionalParams
      info	[Changelog]   - Added Interface PacketCoreControlPlaneVersionsListBySubscriptionNextOptionalParams
      info	[Changelog]   - Added Interface PacketCoreControlPlaneVersionsListBySubscriptionOptionalParams
      info	[Changelog]   - Added Interface SiteDeletePacketCore
      info	[Changelog]   - Added Interface SitesDeletePacketCoreOptionalParams
      info	[Changelog]   - Added Type Alias DesiredInstallationState
      info	[Changelog]   - Added Type Alias DiagnosticsPackagesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DiagnosticsPackagesGetResponse
      info	[Changelog]   - Added Type Alias DiagnosticsPackagesListByPacketCoreControlPlaneNextResponse
      info	[Changelog]   - Added Type Alias DiagnosticsPackagesListByPacketCoreControlPlaneResponse
      info	[Changelog]   - Added Type Alias DiagnosticsPackageStatus
      info	[Changelog]   - Added Type Alias InstallationReason
      info	[Changelog]   - Added Type Alias PacketCapturesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias PacketCapturesGetResponse
      info	[Changelog]   - Added Type Alias PacketCapturesListByPacketCoreControlPlaneNextResponse
      info	[Changelog]   - Added Type Alias PacketCapturesListByPacketCoreControlPlaneResponse
      info	[Changelog]   - Added Type Alias PacketCapturesStopResponse
      info	[Changelog]   - Added Type Alias PacketCaptureStatus
      info	[Changelog]   - Added Type Alias PacketCoreControlPlaneVersionsGetBySubscriptionResponse
      info	[Changelog]   - Added Type Alias PacketCoreControlPlaneVersionsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias PacketCoreControlPlaneVersionsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ReinstallRequired
      info	[Changelog]   - Interface Installation has a new optional parameter desiredState
      info	[Changelog]   - Interface Installation has a new optional parameter reasons
      info	[Changelog]   - Interface Installation has a new optional parameter reinstallRequired
      info	[Changelog]   - Interface PacketCoreControlPlane has a new optional parameter diagnosticsUpload
      info	[Changelog]   - Interface PacketCoreControlPlane has a new optional parameter installedVersion
      info	[Changelog]   - Added Enum KnownDesiredInstallationState
      info	[Changelog]   - Added Enum KnownDiagnosticsPackageStatus
      info	[Changelog]   - Added Enum KnownInstallationReason
      info	[Changelog]   - Added Enum KnownPacketCaptureStatus
      info	[Changelog]   - Added Enum KnownReinstallRequired
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Operation PacketCoreControlPlanes.updateTags has a new signature
      info	[Changelog]   - Operation SimGroups.updateTags has a new signature
      info	[Changelog]   - Class MobileNetworkManagementClient has a new signature
      info	[Changelog]   - Interface ManagedServiceIdentity no longer has parameter principalId
      info	[Changelog]   - Interface ManagedServiceIdentity no longer has parameter tenantId
      info	[Changelog]   - Enum KnownBillingSku no longer has value G3
      info	[Changelog]   - Enum KnownBillingSku no longer has value G4
      info	[Changelog]   - Enum KnownManagedServiceIdentityType no longer has value SystemAssigned
      info	[Changelog]   - Enum KnownManagedServiceIdentityType no longer has value SystemAssignedUserAssigned
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from a8cb7f0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.mobilenetwork.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.mobilenetwork.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 21, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mobilenetwork/armmobilenetwork https://apiview.dev/Assemblies/Review/e38a2972c2a14f8daded56bfc3ad9d51
    JavaScript @azure/arm-mobilenetwork https://apiview.dev/Assemblies/Review/411ced5795d6469faca88bc4228f8916
    Java azure-resourcemanager-mobilenetwork https://apiview.dev/Assemblies/Review/dee2647b9485419c877007a1d0f9f09f

    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - https://aka.ms/azsdk/support/specreview-channel.
    Please indicate that this is an ARM-related question in the title of your post by including "[ARM Query]" in the title.

    @openapi-workflow-bot
    Copy link

    Hi @JeetendraJoshi-MSFT! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no breaking changes, i.e. the validation should pass yet it fails, then please explain why in a PR comment and @ the PR assignee.

    @openapi-workflow-bot
    Copy link

    Hi @JeetendraJoshi-MSFT! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @v-jiaodi
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @v-jiaodi
    Copy link
    Member

    @JeetendraJoshi-MSFT please fix CI check error first.

    @JeetendraJoshi-MSFT
    Copy link
    Contributor Author

    Hi @v-jiaodi , in terms of the breaking changes they have been discussed in the following PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/12428

    @v-jiaodi
    Copy link
    Member

    v-jiaodi commented Jun 21, 2023

    @JeetendraJoshi-MSFT The SDK azure-sdk-for-go and Avocado are required, if not fixed or approved, they will block the PR merge.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Jun 21, 2023
    @JeetendraJoshi-MSFT
    Copy link
    Contributor Author

    @v-jiaodi Now the last CI changes remaining are the SDK for powershell, this seems to always break but has been fine to approve prior. This PR does contain breaking changes and as mentioned they were approved in the previous PR. It says for the Swagger APIView to contact you:
    image
    So unsure what to do on that one.

    @v-jiaodi
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @v-jiaodi
    Copy link
    Member

    v-jiaodi commented Jun 25, 2023

    Add label Approved-BreakingChange as mikekistler has already approved it in https://github.com/Azure/azure-rest-api-specs-pr/pull/12428

    @v-jiaodi v-jiaodi added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 25, 2023
    @v-jiaodi
    Copy link
    Member

    Add label ARMSignedOff as mentat9 has already approved it in https://github.com/Azure/azure-rest-api-specs-pr/pull/12428

    @v-jiaodi v-jiaodi removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2023
    @v-jiaodi v-jiaodi added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 25, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2023
    @v-jiaodi
    Copy link
    Member

    @qiaozha @msyyc @raych1 could you help to take a look at the SDK BreakingChange error in this PR? Thanks

    @v-jiaodi
    Copy link
    Member

    @v-jiaodi Now the last CI changes remaining are the SDK for powershell, this seems to always break but has been fine to approve prior. This PR does contain breaking changes and as mentioned they were approved in the previous PR. It says for the Swagger APIView to contact you: image So unsure what to do on that one.

    @JeetendraJoshi-MSFT SDK azure-powershell error can been ignored. The Swagger APIView check has now passed.

    @raych1 raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 26, 2023
    @v-jiaodi v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 26, 2023
    @raych1 raych1 merged commit a8cb7f0 into main Jun 26, 2023
    @raych1 raych1 deleted the published/Azure/azure-rest-api-specs-pr/ssivathas/2023-06-01 branch June 26, 2023 08:37
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    …24528)
    
    * add or modify files
    
    * Removed 2022-12-01-preview and 2021-04-01 APIs
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-BreakingChange-Python new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants