-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'ssivathas/2023-06-01' #24528
[Hub Generated] Publish private branch 'ssivathas/2023-06-01' #24528
Conversation
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12428 |
Hi, @JeetendraJoshi-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
attachedDataNetwork.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
attachedDataNetwork.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
common.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
common.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
dataNetwork.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
dataNetwork.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
mobileNetwork.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
mobileNetwork.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
operation.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
operation.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
packetCoreControlPlane.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
packetCoreControlPlane.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
packetCoreDataPlane.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
packetCoreDataPlane.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
service.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
service.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
sim.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
simGroup.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
simPolicy.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
simPolicy.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
site.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
slice.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
slice.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
ts29571.json | 2023-06-01(76bcb3f) | 2022-11-01(main) |
ts29571.json | 2023-06-01(76bcb3f) | 2022-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/listSimIds' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L315:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites/{siteName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L367:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L576:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L621:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L818:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L857:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims/{simName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L899:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1056:5 |
|
The new version is missing a definition that was found in the old version. Was 'SimGroup' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimGroupPropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'KeyVaultKey' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'Sim' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimPropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'Site' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SitePropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimPolicyResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimState' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'UserAssignedIdentities' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentityType' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'KeyVaultCertificate' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'SimGroupNameParameter' removed or renamed? New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'SimNameParameter' removed or renamed? New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'SiteNameParameter' removed or renamed? New: azure-rest-api-specs/blob/76bcb3fc0d68355bfcf7ddb6ea5f434f5d881081/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The operation id has been changed from 'PacketCoreControlPlaneVersions_ListByResourceGroup' to 'PacketCoreControlPlaneVersions_List'. This will impact generated code. New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L512:7 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L356:7 |
|
The '$ref' property points to different models in the old and new versions. New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L1001:9 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L539:9 |
|
The '$ref' property points to different models in the old and new versions. New: Microsoft.MobileNetwork/stable/2023-06-01/packetCoreControlPlane.json#L201:13 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L201:13 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-2023-06 | package-2023-06(76bcb3f) | default(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.MobileNetwork/stable/2023-06-01/operation.json#L77 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MobileNetwork/stable/2023-06-01/operation.json#L86 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MobileNetwork/stable/2023-06-01/sim.json#L604 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-2023-06; Prod region: Not deployed; Canary region: Not deployed
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the |
Hi @JeetendraJoshi-MSFT! The automation detected breaking changes in this pull request. As a result, it added the |
Hi @JeetendraJoshi-MSFT! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@JeetendraJoshi-MSFT please fix CI check error first. |
Hi @v-jiaodi , in terms of the breaking changes they have been discussed in the following PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/12428 |
@JeetendraJoshi-MSFT The SDK azure-sdk-for-go and Avocado are required, if not fixed or approved, they will block the PR merge. |
@v-jiaodi Now the last CI changes remaining are the SDK for powershell, this seems to always break but has been fine to approve prior. This PR does contain breaking changes and as mentioned they were approved in the previous PR. It says for the Swagger APIView to contact you: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Add label |
Add label |
@JeetendraJoshi-MSFT SDK azure-powershell error can been ignored. The Swagger APIView check has now passed. |
…24528) * add or modify files * Removed 2022-12-01-preview and 2021-04-01 APIs
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.