From 1576ae82158549ea85e034aa9af699d5abbb03af Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Fri, 5 Nov 2021 10:45:16 -0700 Subject: [PATCH 1/2] Fix template and add checkbox to update CHANGELOG --- .../PULL_REQUEST_TEMPLATE.md | 25 ------------------- .../pull_request_template.md | 17 +++++++++++++ 2 files changed, 17 insertions(+), 25 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index 19e599ebe1ab0..0000000000000 --- a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,25 +0,0 @@ - -# Azure SDK for Java Pull Request Template Guide - -Thank you for your interest in contributing to Azure SDK for Java. - -## Description - - ---- - -This checklist is used to make sure that common guidelines for a pull request are followed. -- [ ] Please add REST spec PR link to the SDK PR -- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md).** -- [ ] **The pull request does not introduce breaking changes.** - -### [General Guidelines](../../CONTRIBUTING.md#Pull Requests) -- [ ] Title of the pull request is clear and informative. -- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](../../CONTRIBUTING.md#Pull Requests). - -### [Testing Guidelines](../../CONTRIBUTING.md#Building and Testing) -- [ ] Pull request includes test coverage for the included changes. diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 0000000000000..dc5fc46a5589d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,17 @@ +# Description + +Please add an informative description that covers that changes made by the pull request and link all relevant issues. + +If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. + +# All SDK Contribution checklist: +- [ ] **The pull request does not introduce [breaking changes]** +- [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** +- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md).** + +## [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) +- [ ] Title of the pull request is clear and informative. +- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). + +### [Testing Guidelines](../../CONTRIBUTING.md#building-and-unit-testing) +- [ ] Pull request includes test coverage for the included changes. From a0af8640319b5046463f23b517abc91b77351ece Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Mon, 8 Nov 2021 09:56:18 -0800 Subject: [PATCH 2/2] move file level up --- .../pull_request_template.md => PULL_REQUEST_TEMPLATE.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE/pull_request_template.md => PULL_REQUEST_TEMPLATE.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE/pull_request_template.md rename to .github/PULL_REQUEST_TEMPLATE.md