Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sb integration bug #25501

Merged
merged 10 commits into from
Nov 19, 2021
Merged

Fix sb integration bug #25501

merged 10 commits into from
Nov 19, 2021

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Nov 18, 2021 •
edited
Loading

Fix spring sb integartion bugs and eh message bugs.
eh:

  1. add client as a parameter of listener
  2. call remove method of listener when client is destroyed.
  3. fix bug of thread safety.

sb:

  1. modify unsuitable class name of autoconfiguration
  2. add default message converter of integration listener.

@yiliuTo yiliuTo added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. azure-spring-eventhubs Spring event hubs related issues. labels Nov 18, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@yiliuTo
Copy link
Member Author

yiliuTo commented Nov 18, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Nov 19, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stliu stliu merged commit 6969085 into Azure:feature/azure-spring-cloud-4.0 Nov 19, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Sep 12, 2023
@guitarsheng @jiec-msft
@yilims @domainname @ninpan-ms
CodeGen from PR 25501 in Azure/azure-rest-api-specs
d03fa62 
Add 2023-09-01-preview for appplatform (Azure#25501)

* Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* feat: fragment support swagger change (Azure#25314)

* Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (Azure#25322)

* support war file deployment (Azure#25312)

Co-authored-by: Yi Li <yili7@microsoft.com>

* Fix exmaple for api portal api try-out feature (Azure#25337)

* Add property `autoSync` in `KeyVaultCertificateProperties` (Azure#25331)

* Add gateway apm reference (Azure#25408)

* Add expand parameter for list deployment (Azure#25411)

* Add expand parameter for list deployments API (Azure#25471)

* change order of expand (Azure#25587)

* Update readme.go.md (Azure#25634)

* Update readme.go.md

* Update readme.python.md

* Update readme.ruby.md

* Revert api portal try out feature (Azure#25677)

Fix exmaple for api portal api try-out feature (Azure#25337)"

* add API to list all server versions (Azure#25720)

* add API to list all server versions

* refine list supported server version API

* refine description

---------

Co-authored-by: Yi Li <yili7@microsoft.com>

* use enum for autoSync (Azure#25722)

* Update appplatform.json (Azure#25724)

* certificate - rename enum (Azure#25723)

* use enum for autoSync

* rename enum

* rename enum

---------

Co-authored-by: guitarsheng <85543793+guitarsheng@users.noreply.github.com>
Co-authored-by: Mason Chen <jiec@microsoft.com>
Co-authored-by: Yi Li <109205537+yilims@users.noreply.github.com>
Co-authored-by: Yi Li <yili7@microsoft.com>
Co-authored-by: Jeff <1830237+domainname@users.noreply.github.com>
Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@moarychan moarychan Awaiting requested review from moarychan

@stliu stliu Awaiting requested review from stliu

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. azure-spring-servicebus Spring service bus related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiliuTo @saragluna @stliu