Use reflection to properly support Vert.x 5.x #45709
Merged
+41
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #45386
Use reflection to create Vert.x
HttpClientto properly support Vert.x 5.x while keeping dependency on Vert.x 4.5.While Vert.x 5.x and Vert.x 4.5 both have
Vertx.createHttpClient(HttpClientOptions), there is binary incompatibility which results in an exception thrown whenazure-core-http-vertx's Vert.x 4.5 version is overridden to use Vert.x 5.x. Using reflection to create the Vert.xHttpClientresolves this issue.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines