Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-queue] queue improvements #12331

Closed
ljian3377 opened this issue Nov 6, 2020 · 2 comments
Closed

[storage-queue] queue improvements #12331

ljian3377 opened this issue Nov 6, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. cross-language alignment mark issues need to be aligned across different languages feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@ljian3377
Copy link
Member

ljian3377 commented Nov 6, 2020

Quoting Kamil,

Azure/azure-sdk-for-net#14211 (one message):
I was working in a codebase in .NET where I had a need to receive/peek just one message and found that it requires lot of repetitive code to achieve such a simple thing. So I went ahead and added such convenience. I can see that we already have something like that in Java but not in Python.
I think in .NET and Java this is needed as compiler makes you write too much code to just request 1 message and extract it from collection. I’m not sure how hectic is this in Python and JS, so I suggest to give it a try and see if it improves CX – if it does then I suggest adding that.

As for base64 encoding.
We have a prototype in .NET how this would look like here Azure/azure-sdk-for-net#14476 . In addition to base64 knob in options it also brings in “BinaryData” which gives an abstraction to serialize/deserialize to/from byte array. In V11 we used to have ability to send queue messages with byte arrays, so this is going to bring back that option (plus some other benefits). The BinaryData started in the Azure.Core but they ended up adding it to .NET dotnet/designs#155 . BinaryData is not yet shipped but as soon as it is we’re going to add this to Queue SDK.
As far as I know there is BinaryData concept in Java https://github.com/Azure/azure-sdk-for-java/blob/4600d55e77a44e51cd458e9e6a94ebf5e1553774/sdk/core/azure-core-experimental/src/main/java/com/azure/core/experimental/util/BinaryData.java#L57 (still work in progress).
For Python and JS I think we should follow up with One SDK crews to see what’s the equivalent of BinaryData. I suspect there might be none since both can take “union types” (i.e. you can pass string or byte array without adding overload) – in that case we could go ahead and implement base64 encoding in those languages as a QueueClient options knob (see initial .NET PR for reference Azure/azure-sdk-for-net#14476 ). But I’d wait until .NET goes first and use it as a base how to model this in other languages (i.e. how to name new client options).

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@ljian3377 ljian3377 added the Storage Storage Service (Queues, Blobs, Files) label Nov 6, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@ljian3377 ljian3377 added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 6, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@ljian3377 ljian3377 added the feature-request This issue requires a new behavior in the product in order be resolved. label Nov 6, 2020
@ljian3377 ljian3377 self-assigned this Nov 6, 2020
@ljian3377 ljian3377 added the cross-language alignment mark issues need to be aligned across different languages label Nov 6, 2020
@ljian3377
Copy link
Member Author

@EmmaZhu EmmaZhu modified the milestones: [2021] June, [2021] August Jul 9, 2021
@xirzec xirzec modified the milestones: [2022] February, [2022] June May 17, 2022
@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec removed this from the 2022-08 milestone Aug 9, 2022
@xirzec xirzec added this to the 2022-09 milestone Aug 9, 2022
@xirzec xirzec modified the milestones: 2022-09, 2022-12 Nov 1, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
Copy link

Hi @ljian3377, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. cross-language alignment mark issues need to be aligned across different languages feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants