From 70bc6d2639934221de0c6e65cdaa8d936a4324e6 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 22 Jun 2021 14:44:54 -0700 Subject: [PATCH 1/2] added changelogs for breaking changes --- sdk/core/core-http/CHANGELOG.md | 2 ++ sdk/core/core-tracing/CHANGELOG.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/sdk/core/core-http/CHANGELOG.md b/sdk/core/core-http/CHANGELOG.md index b0602c0a0a9a..dc3b9b2a11ad 100644 --- a/sdk/core/core-http/CHANGELOG.md +++ b/sdk/core/core-http/CHANGELOG.md @@ -6,6 +6,8 @@ ### Breaking Changes +- Updated @azure/core-tracing to version `1.0.0-preview.12`. See [@azure/core-tracing CHANGELOG](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-tracing/CHANGELOG.md) for details about breaking changes with tracing. + ### Key Bugs Fixed ### Fixed diff --git a/sdk/core/core-tracing/CHANGELOG.md b/sdk/core/core-tracing/CHANGELOG.md index d6aac66e465c..fc739205d2da 100644 --- a/sdk/core/core-tracing/CHANGELOG.md +++ b/sdk/core/core-tracing/CHANGELOG.md @@ -7,6 +7,8 @@ ### Breaking Changes - Removed `OpenCensusSpanWrapper` and `OpenCensusTracerWrapper` from the public API. Customers using these wrappers should migrate to using `OpenTelemetry` directly. [PR #15770](https://github.com/Azure/azure-sdk-for-js/pull/15770) +- Update `@azure/core-tracing` to version 1.0.0-preview.12. This brings core-tracing up to date with `@opentelemetry/api@1.0.0`. + - Breaking changes are internal, and supported by `@azure/core-http@1.2.7` ## 1.0.0-preview.11 (2021-03-30) From 780710bd06726bea086d575b2c9e48fecfdf1e88 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 22 Jun 2021 15:23:02 -0700 Subject: [PATCH 2/2] feedback --- sdk/core/core-http/CHANGELOG.md | 2 +- sdk/core/core-tracing/CHANGELOG.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/core/core-http/CHANGELOG.md b/sdk/core/core-http/CHANGELOG.md index dc3b9b2a11ad..4af768b481ea 100644 --- a/sdk/core/core-http/CHANGELOG.md +++ b/sdk/core/core-http/CHANGELOG.md @@ -6,7 +6,7 @@ ### Breaking Changes -- Updated @azure/core-tracing to version `1.0.0-preview.12`. See [@azure/core-tracing CHANGELOG](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-tracing/CHANGELOG.md) for details about breaking changes with tracing. +- Updated @azure/core-tracing to version `1.0.0-preview.12`. See [@azure/core-tracing CHANGELOG](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-tracing/CHANGELOG.md) for details about breaking changes with tracing. ### Key Bugs Fixed diff --git a/sdk/core/core-tracing/CHANGELOG.md b/sdk/core/core-tracing/CHANGELOG.md index fc739205d2da..a309dea716be 100644 --- a/sdk/core/core-tracing/CHANGELOG.md +++ b/sdk/core/core-tracing/CHANGELOG.md @@ -8,7 +8,7 @@ - Removed `OpenCensusSpanWrapper` and `OpenCensusTracerWrapper` from the public API. Customers using these wrappers should migrate to using `OpenTelemetry` directly. [PR #15770](https://github.com/Azure/azure-sdk-for-js/pull/15770) - Update `@azure/core-tracing` to version 1.0.0-preview.12. This brings core-tracing up to date with `@opentelemetry/api@1.0.0`. - - Breaking changes are internal, and supported by `@azure/core-http@1.2.7` + - `Span#context` was renamed to `Span#spanContext`. This change is supported in `@azure/core-http@1.2.7`. ## 1.0.0-preview.11 (2021-03-30)