[Communication][Chat] Chat SDK 1.3.2-beta.1 release #25295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jpeng-ms
commented
Mar 18, 2023
jpeng-ms
commented
Mar 18, 2023
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
3 tasks
JoshuaLai
reviewed
Mar 23, 2023
JoshuaLai
reviewed
Mar 23, 2023
JoshuaLai
requested changes
Mar 23, 2023
JoshuaLai
approved these changes
Mar 24, 2023
joheredi
approved these changes
Mar 24, 2023
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Aug 23, 2023
Release sql microsoft.sql 2023 02 01 preview (Azure#25293) * Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add mi refresh API (Azure#24093) * add mi refresh API * remove stray character * add examples * fix lro error * fix lro error only in example * fixing prettier issue * Test commit - adding error schema * Test2 * Test - changing error type * Revert "Test - changing error type" This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064. * Reverting 3 test commits * Test - adding commong error type reference * fix type format errors --------- Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> * Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221) * Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132) * Added the swagger spec and example json files for failvoer group API update in V2023-020-1 * Corrected the FailoverGroupGet.json example * Updated the auto-generated FailoverGroups.json Fixed FailoverGroups.json swagger arm-id attribute for databases field * Added the missing headers field manually * Fix FailoverGroups.json --------- Co-authored-by: Sharan Singh <sharanlobana@gmail.com> * Changes to Location Capabilities (Azure#24209) * Loc cap changes * removing changes not related to my changes in dsmain * DAG API 2023-02-01 (Azure#24108) * add new dag api version * Update swagger * Update swagger * patch resource * make replicationMode writable * Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224) * Add FreeLimitExhaustion Capability in 2023-02-01-preview API * Change property from name to exhaustionBehaviorType * generate swagger for LocationCapabilites (Azure#24290) * inital commit for LTR Policy Immutability (Azure#24347) * inital commit for immutable ltr backups (Azure#24349) * Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305) * Update swagger files for Server API * Add v5 tag for Servers * Restore none for minimal TLS version * Add auto rotation param to databases api (Azure#24339) * Add auto rotation param to databases api * add armid * Adding IsFreemium and CreateTime to Get MI API (Azure#24239) * Updated the examples for LTR Policies and LTR Backups (Azure#24821) * Updated the examples for LTR Policies and LTR Backups * Not sure why makeBackupsImmutable got deleted * updating swagger files for enum name changes (Azure#24742) * Carrying over minor changes for the 2023-02-01-preview release (Azure#25177) * Carrying over minor changes for the 2023-02-01-preview release * Reverting example files that didn't have DsMainDev side changes, and fixing prettier check * Fixes for LTR examples with model validation and prettier check for ServerDelete * Reverting LTR changes * Adding arm-id to serversjson * swagger changes for adding new parameter in dc telemetry (Azure#24834) * testing push * reverting push * swagger files for DC add parameter change * delete added file * modified swagger files without Venkat's change * modified swagger files * changed modelAsString to true * add example files * add example files * fix mismatch * Removing Pattern from ManagedInstance to avoid incident (Azure#25295) * Carrying over minor changes for the 2023-02-01-preview release * Reverting example files that didn't have DsMainDev side changes, and fixing prettier check * Fixes for LTR examples with model validation and prettier check for ServerDelete * Reverting LTR changes * Adding arm-id to serversjson * Removing the Pattern property from ManagedInstances.json as it should not be present and will cause issues in downstream client generation --------- Co-authored-by: guptanitish-ms <68623376+guptanitish-ms@users.noreply.github.com> Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> Co-authored-by: lobashh <56324552+lobashh@users.noreply.github.com> Co-authored-by: Sharan Singh <sharanlobana@gmail.com> Co-authored-by: Aleksand4rZivanovic <60347245+Aleksand4rZivanovic@users.noreply.github.com> Co-authored-by: a-lazarlazic <106240189+a-lazarlazic@users.noreply.github.com> Co-authored-by: mykolian <34487118+mykolian@users.noreply.github.com> Co-authored-by: Srna Nikolic <133877309+srnanikolicmdcs@users.noreply.github.com> Co-authored-by: rebeccaxu-ms <104461363+rebeccaxu-ms@users.noreply.github.com> Co-authored-by: LeiWang3 <84884417+LeiWang3@users.noreply.github.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Nikola Mirkovic <135128634+nmirkovic-microsoft@users.noreply.github.com> Co-authored-by: pmahanandire <104351468+pmahanandire@users.noreply.github.com> Co-authored-by: nidhigupta <139312437+Nidhi-Gupta6198@users.noreply.github.com>
AmyL219
reviewed
Oct 10, 2023
| /** Identifies a participant in Azure Communication services. A participant is, for example, a phone number or an Azure communication user. This model must be interpreted as a union: Apart from rawId, at most one further property may be set. */ | ||
| initiator?: CommunicationIdentifierKind; | ||
| } | ||
|
|
||
| /** An attachment in a chat message. */ |
There was a problem hiding this comment.
Could we directly export this type from generate source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/communication-chat
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
Added inline image support
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Added new data model to accommodate changes on the service side
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists