Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] [Test Proxy] [Asset Sync] Updates to the docs #25350

Merged
merged 14 commits into from
Mar 28, 2023

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Mar 23, 2023

Updates the outdated docs, minor improves the current documentation and the migration guides.

Also created a wiki - https://github.com/Azure/azure-sdk-for-js/wiki/Golden-Testing-Commands

@ghost ghost added the dev-tool Issues related to the Azure SDK for JS dev-tool label Mar 23, 2023
@HarshaNalluru HarshaNalluru requested a review from MaryGao March 23, 2023 05:59
@HarshaNalluru HarshaNalluru requested a review from xirzec March 23, 2023 06:11
@HarshaNalluru HarshaNalluru marked this pull request as ready for review March 23, 2023 06:11
Copy link
Member

@timovv timovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements! I had a couple of comments, but overall looks good to me.

sdk/test-utils/recorder/GoldenCommands.md Outdated Show resolved Hide resolved
sdk/test-utils/recorder/MIGRATION.md Outdated Show resolved Hide resolved
@HarshaNalluru HarshaNalluru merged commit f37c3f5 into Azure:main Mar 28, 2023
@HarshaNalluru HarshaNalluru deleted the harshan/asset-sync-update branch March 29, 2023 10:15
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Nov 9, 2023
Release app microsoft.app 2023 08 01 preview (Azure#26352)

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add type to Certificate (Azure#25380)

* Add type to Certificate

* lint

* Add gpus property to AvailableWorkloadProfiles. (Azure#25328)

* Add gpus property to AvailableWorkloadProfiles.

* Fix.

* Pauld/re add build and builder (Azure#25442)

* cherry picked the build and builder updates

* some more cleanup

* added arm id format, removed extra properties, and named the resource provisioning states

* Add OT and AI config (Azure#25350)

* Add OT and AI config

* resolve comments

* Add service bind properties to dapr component (Azure#25781)

* dapr component sb-bind definition add

* fix

* ran npx prettier

* npx prettier

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* Adding patching scenario ARM API (Azure#25446)

* cherry picked the build and builder updates

* some more cleanup

* Adding patching scenario and samples

* Added to readme

* Lint fix

* Linting

* Linting error fix

* Addressed comments and added extra properties

* Linting

* Fixing patch skip post action

* Linting

* Addressing comments

* Reverting patchDetails changes

* Fixing pipeline error

* Linting

* Removed invalid required tag

* Fixed examples

* Addressed comments

---------

Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>

* Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (Azure#25631)

* ACA Dapr Subscription: WIP

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add Dapr Subscription examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* complete examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add DaprSubscription descriptions

Signed-off-by: Bernd Verst <github@bernd.dev>

* include updated readme

Signed-off-by: Bernd Verst <github@bernd.dev>

* fix casing

Signed-off-by: Bernd Verst <github@bernd.dev>

* formatting

Signed-off-by: Bernd Verst <github@bernd.dev>

* Use Types v5

Signed-off-by: Bernd Verst <github@bernd.dev>

* Revert "Use Types v5"

v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch.

This reverts commit 6a43aacf16132ff1918cbeb9d9b15c74b3a55a78.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Support log streaming on build resource (Azure#25902)

* updated the build resource to support build upload and log streaming, with a token to be passed in via header

* add x-ms-secret and update buildendpoint -> endpoint

* retrieve log stream and upload endpoint tokens through post requests, as they are secrets

* remove secret flag from tokenendpoint property, as we expect users to retrieve it

* rename file

* updated format of how build object returns auth token

* fix example

* added expiration date to token response

* fix auth token to also include build resource information

* renamed getAuthToken -> listAuthToken and removed resource information from token response

* fix examples

* updated samples to be more accurate

* Update serviceBinds with clientType and customizedKeys (Azure#26111)

* Update serviceBinds with clientType and customizedKeys

* force ci

* fix missing }

---------

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>

* Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (Azure#26107)

* Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview

Signed-off-by: Bernd Verst <github@bernd.dev>

* Update deletion return code

* Fix variable name

* Remove invalid status code from example

* prettify

* Register new resource in readme

* Remove existing import cycle

* Use integers not integer strings

* Fix delete status codes

* More changes

* Update examples

* Revert "Remove existing import cycle" which causes unrelated failures

This reverts commit 8ce1a74f9d12b333c43c324f1b2250a64a0f1add.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add API spec for ContainerApp Resiliency (Azure#25732)

Signed-off-by: Hal Spang <halspang@microsoft.com>

* Add extendedlocation for job (Azure#26196)

* Add extendedlocation for job

* Add sample for container apps on connectedEnvironment

* Fixes for examples

* Fix connected environment example

* Update old examples

* removing SourceToCloud patching from 08-01-preview (Azure#26245)

* Add diagnostic routes to Container App Jobs (Azure#26227)

* Add diagnostic routes to Container App Jobs

* Update

* Update

* Update

* Update

* Update

* Update

* Update operationIds

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Update app resiliency rest api spec (Azure#26357)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix ACA component resiliency examples (Azure#26441)

* Fix arm review comments for container app (Azure#26455)

* update

* update

* update

* Fix SDK build error for Microsoft.App (Azure#26416)

* Fix SDK build error for Microsoft.App

* Update

* update

* update

* update

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix arm review comments for container app (Azure#26479)

* fix

* update

* update

* Fix detectorProperties request path (Azure#26431)

* fix list exception

* change param to enum

* fix lint error

* revert not working changes

* fix enum

* rearrange

---------

Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Enable dynamicJsonColumns for log analytics configuration (Azure#26432)

* Enable dynamicJsonColumn for log analysis configuration

* Add missed s

* Fix code style

* Update container app usages value to float (Azure#26448)

* update

* update

* update

* Fix App Resiliency retry example (Azure#26560)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix lint warning for container app (Azure#26523)

* fix warning

* fix warning

* upate

---------

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
Co-authored-by: Bernd Verst <bernd.verst@microsoft.com>
Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: halspang <70976921+halspang@users.noreply.github.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com>
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants