Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Fix SplitTextSkill missing properties #31882

Open
wants to merge 1 commit into
base: search/stable
Choose a base branch
from
+14 −2
Open

[Search] Fix SplitTextSkill missing properties #31882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sdk/search/search-documents/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
# Release History

## 12.1.1 (Unreleased)

### Bugs Fixed

- Exposed missing configuration for page-based text splitting in `SplitTextSkill` [#31882](https://github.com/Azure/azure-sdk-for-js/pull/31882)

## 12.1.0 (2024-07-24)

### Features Added

- Added support for text queries against vector fields [#30494](https://github.com/Azure/azure-sdk-for-js/pull/29597)
- Added support for text queries against vector fields [#30494](https://github.com/Azure/azure-sdk-for-js/pull/30494)
- Create text queries against vector fields with the `VectorizedTextQuery` variant of `VectorQuery`. Such queries are supported by configuring the corresponding index field with a `VectorSearchVectorizer`. This configuration describes a delegate, which the service uses to generate vector embeddings for the query text.
- Added `AzureOpenAIEmbeddingSkill` to allow for `SearchIndexer`s to populate embedding fields at index-time.
- Added index configuration for vector quantization through `VectorSearchCompression`
Expand Down
2 changes: 2 additions & 0 deletions sdk/search/search-documents/review/search-documents.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2531,8 +2531,10 @@ export interface SoftDeleteColumnDeletionDetectionPolicy extends BaseDataDeletio
// @public
export interface SplitSkill extends BaseSearchIndexerSkill {
defaultLanguageCode?: SplitSkillLanguage;
maximumPagesToTake?: number;
maxPageLength?: number;
odatatype: "#Microsoft.Skills.Text.SplitSkill";
pageOverlapLength?: number;
textSplitMode?: TextSplitMode;
}

Expand Down
6 changes: 5 additions & 1 deletion sdk/search/search-documents/src/serviceModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2364,12 +2364,16 @@ export interface SentimentSkill extends BaseSearchIndexerSkill {
export interface SplitSkill extends BaseSearchIndexerSkill {
/** Polymorphic discriminator, which specifies the different types this object can be */
odatatype: "#Microsoft.Skills.Text.SplitSkill";
/** A value indicating which language code to use. Default is en. */
/** A value indicating which language code to use. Default is `en`. */
defaultLanguageCode?: SplitSkillLanguage;
/** A value indicating which split mode to perform. */
textSplitMode?: TextSplitMode;
/** The desired maximum page length. Default is 10000. */
maxPageLength?: number;
/** Only applicable when textSplitMode is set to 'pages'. If specified, n+1th chunk will start with this number of characters/tokens from the end of the nth chunk. */
pageOverlapLength?: number;
/** Only applicable when textSplitMode is set to 'pages'. If specified, the SplitSkill will discontinue splitting after processing the first 'maximumPagesToTake' pages, in order to improve performance when only a few initial pages are needed from each document. */
maximumPagesToTake?: number;
}

/** A skill to translate text from one language to another. */
Expand Down
Loading