[core-lro] Using await to test that pollUntilDone throws #7530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
approved these changes
Feb 25, 2020
mikeharder
approved these changes
Feb 25, 2020
sadasant
added a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
May 8, 2020
Based on this: Azure#7530
sadasant
added a commit
that referenced
this pull request
May 9, 2020
…lds work (#8782) * fixing the build * Update macOS.10.13 to macOS.10.15 (#7662) * Pinning to Typedoc 0.16.x until further investigation (#7850) * core-lro test fix Based on this: #7530 * just as string was good enough * I forgot I had changed this too Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: KarishmaGhiya <kaghiya@microsoft.com>
sadasant
added a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
May 12, 2020
Based on this: Azure#7530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the changed test passes using tslib 1.10.0, but not with tslib 1.11.0. This is due to the fact that tslib 1.11.0 includes a fix to the async scheduling generated by TypeScript microsoft/tslib#70
To address this, this PR makes a slight change that properly awaits for the pollUntilDone method to finish before asserting the exception.