change the tobicepexpression as an extension method

Author: ArcturusZhang

sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.net8.0.cs

@@ -36,6 +36,10 @@ public void CopyTo(System.Collections.Generic.KeyValuePair<string, Azure.Provisi
         System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
         public bool TryGetValue(string key, [System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute(false)] out Azure.Provisioning.BicepValue<T> value) { throw null; }
     }
+    public static partial class BicepExpressionExtensions
+    {
+        public static Azure.Provisioning.Expressions.BicepExpression ToBicepExpression(this Azure.Provisioning.IBicepValue bicepValue) { throw null; }
+    }
     public partial class BicepList<T> : Azure.Provisioning.BicepValue, System.Collections.Generic.ICollection<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IEnumerable<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IList<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IReadOnlyCollection<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IReadOnlyList<Azure.Provisioning.BicepValue<T>>, System.Collections.IEnumerable
     {
         public BicepList() { }

sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.netstandard2.0.cs

@@ -36,6 +36,10 @@ public void CopyTo(System.Collections.Generic.KeyValuePair<string, Azure.Provisi
         System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
         public bool TryGetValue(string key, out Azure.Provisioning.BicepValue<T> value) { throw null; }
     }
+    public static partial class BicepExpressionExtensions
+    {
+        public static Azure.Provisioning.Expressions.BicepExpression ToBicepExpression(this Azure.Provisioning.IBicepValue bicepValue) { throw null; }
+    }
     public partial class BicepList<T> : Azure.Provisioning.BicepValue, System.Collections.Generic.ICollection<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IEnumerable<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IList<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IReadOnlyCollection<Azure.Provisioning.BicepValue<T>>, System.Collections.Generic.IReadOnlyList<Azure.Provisioning.BicepValue<T>>, System.Collections.IEnumerable
     {
         public BicepList() { }

sdk/provisioning/Azure.Provisioning/src/BicepExpressionExtensions.cs

@@ -0,0 +1,36 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Azure.Provisioning.Expressions;
+
+namespace Azure.Provisioning;
+
+/// <summary>
+/// Provide extension methods for working with Bicep expressions.
+/// </summary>
+public static class BicepExpressionExtensions
+{
+    public static BicepExpression ToBicepExpression(this IBicepValue bicepValue)
+    {
+        // if self is set, we could build an expression as a reference of this member
+        if (bicepValue.Self is not null)
+        {
+            return bicepValue.Self.GetReference();
+        }
+        // if self is not set, but the value of this is an expression, we return that expression
+        else if (bicepValue.Kind == BicepValueKind.Expression)
+        {
+            return bicepValue.Expression ?? BicepSyntax.Null();
+        }
+        // otherwise, we return whatever this compiles into
+        else
+        {
+            return bicepValue.Compile();
+        }
+    }
+}

sdk/provisioning/Azure.Provisioning/src/BicepValue.cs

@@ -5,6 +5,7 @@
 using System.ComponentModel;
 using Azure.Provisioning.Expressions;
 using Azure.Provisioning.Primitives;
+using Azure.Provisioning.Utilities;
 
 namespace Azure.Provisioning;
 
@@ -132,23 +133,4 @@ internal virtual void Assign(IBicepValue source)
         value._kind == BicepValueKind.Expression ?
             value._expression :
             value._self?.GetReference();
-
-    public BicepExpression ToBicepExpression()
-    {
-        // if self is set, we could build an expression as a reference of this member
-        if (_self is not null)
-        {
-            return _self.GetReference();
-        }
-        // if self is not set, but the value of this is an expression, we return that expression
-        else if (_kind == BicepValueKind.Expression)
-        {
-            return _expression ?? BicepSyntax.Null();
-        }
-        // otherwise, we return whatever this compiles into
-        else
-        {
-            return Compile();
-        }
-    }
 }

sdk/provisioning/Azure.Provisioning/src/Primitives/ProvisionableConstruct.cs

@@ -363,20 +363,4 @@ protected T DefineModelProperty<T>(
         string? format = null)
         where T : ProvisionableConstruct, new()
         => DefineModelProperty(propertyName, bicepPath, new T(), isOutput, isRequired, isSecure, format);
-
-    public BicepExpression ToBicepExpression()
-    {
-        if (_kind == BicepValueKind.Expression)
-        {
-            return _expression ?? BicepSyntax.Null();
-        }
-        else if (_self is not null)
-        {
-            return _self.GetReference();
-        }
-        else
-        {
-            return ((IBicepValue)this).Compile();
-        }
-    }
 }