From 9de24560f6fe07ec5d98992b7d2d1e0dbdea7309 Mon Sep 17 00:00:00 2001
From: m-nash <64171366+m-nash@users.noreply.github.com>
Date: Tue, 15 Jun 2021 21:45:14 -0700
Subject: [PATCH] remove unused interfaces (#21898)

* update to be inside core namespace

* update proto references to removed namespace

* remove unused interfaces
---
 .../src/IDeletableResource.cs                 |  52 ------
 .../src/ITaggableResource.cs                  | 163 ------------------
 .../authorization/RoleAssignmentOperations.cs |   2 +-
 .../compute/AvailabilitySetOperations.cs      |   2 +-
 .../compute/VirtualMachineOperations.cs       |   2 +-
 .../VirtualMachineScaleSetOperations.cs       |   2 +-
 .../network/LoadBalancerOperations.cs         |   2 +-
 .../network/NetworkInterfaceOperations.cs     |   2 +-
 .../network/NetworkSecurityGroupOperations.cs |   2 +-
 .../network/PublicIpAddressOperations.cs      |   2 +-
 .../Proto.Client/network/SubnetOperations.cs  |   2 +-
 .../network/VirtualNetworkOperations.cs       |   2 +-
 12 files changed, 10 insertions(+), 225 deletions(-)
 delete mode 100644 sdk/resourcemanager/Azure.ResourceManager.Core/src/IDeletableResource.cs
 delete mode 100644 sdk/resourcemanager/Azure.ResourceManager.Core/src/ITaggableResource.cs

diff --git a/sdk/resourcemanager/Azure.ResourceManager.Core/src/IDeletableResource.cs b/sdk/resourcemanager/Azure.ResourceManager.Core/src/IDeletableResource.cs
deleted file mode 100644
index 3fba06521f18e..0000000000000
--- a/sdk/resourcemanager/Azure.ResourceManager.Core/src/IDeletableResource.cs
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT License.
-
-using System.Threading;
-using System.Threading.Tasks;
-
-namespace Azure.ResourceManager.Core
-{
-    /// <summary>
-    /// Interface for operations to delete a resource
-    /// </summary>
-    public interface IDeletableResource
-    {
-        /// <summary>
-        /// Delete the resource.
-        /// </summary>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> The status of the delete operation. </returns>
-        Response Delete(CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Delete the resource.
-        /// </summary>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> A <see cref="Task"/> that on completion returns the status of the delete operation. </returns>
-        Task<Response> DeleteAsync(CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Delete the resource.
-        /// </summary>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> A <see cref="Operation{Response}"/> which allows the caller to control polling and waiting for resource deletion.
-        /// The operation yields the final http response to the delete request when complete. </returns>
-        /// <remarks>
-        /// <see href="https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-longrunning">Details on long running operation object.</see>
-        /// </remarks>
-        Operation StartDelete(CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Delete the resource.  This call returns a Task that blocks until the delete operation is accepted on the service.
-        /// </summary>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns> A <see cref="Task"/> that on completion returns a <see cref="Operation{Response}"/> which
-        /// allows the caller to control polling and waiting for resource deletion.
-        /// The operation yields the final http response to the delete request when complete. </returns>
-        /// <remarks>
-        /// <see href="https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-longrunning">Details on long running operation object.</see>
-        /// </remarks>
-        Task<Operation> StartDeleteAsync(CancellationToken cancellationToken = default);
-    }
-}
diff --git a/sdk/resourcemanager/Azure.ResourceManager.Core/src/ITaggableResource.cs b/sdk/resourcemanager/Azure.ResourceManager.Core/src/ITaggableResource.cs
deleted file mode 100644
index b22a9500285c8..0000000000000
--- a/sdk/resourcemanager/Azure.ResourceManager.Core/src/ITaggableResource.cs
+++ /dev/null
@@ -1,163 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT License.
-
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
-
-namespace Azure.ResourceManager.Core
-{
-    /// <summary>
-    /// Interface for operations that allow manipulating resource tags.
-    /// </summary>
-    /// <typeparam name="TIdentifier"> The identifier type for this resource. </typeparam>
-    /// <typeparam name="TOperations"> The typed operations for a specific resource. </typeparam>
-    public interface ITaggableResource<TIdentifier, TOperations> 
-        where TOperations : ResourceOperationsBase<TIdentifier, TOperations>
-        where TIdentifier : TenantResourceIdentifier
-    {
-        /// <summary>
-        /// Add a tag to the resource.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="value"> The tag value. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns>An <see cref="Response{TOperations}"/> that allows the user to control polling and waiting for Tag completion.</returns>
-        Response<TOperations> AddTag(
-            string key,
-            string value,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Add a tag to the resource.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="value"> The tag value. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns> A <see cref="Task"/> that performs the Tag operation.  The Task yields an an
-        /// <see cref="Response{TOperations}"/> that allows the user to control polling and waiting for
-        /// Tag completion. </returns>
-        Task<Response<TOperations>> AddTagAsync(
-            string key,
-            string value,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Add a tag to the resource.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="value"> The tag value. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns>An <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for Tag completion.</returns>
-        Operation<TOperations> StartAddTag(
-            string key,
-            string value,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Add a tag to the resource.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="value"> The tag value. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns> A <see cref="Task"/> that performs the Tag operation.  The Task yields an an
-        /// <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for
-        /// Tag completion. </returns>
-        Task<Operation<TOperations>> StartAddTagAsync(
-            string key,
-            string value,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Set the resource tags.
-        /// </summary>
-        /// <param name="tags"> The resource tags. </param>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> The status of the delete operation. </returns>
-        Response<TOperations> SetTags(
-            IDictionary<string, string> tags,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Set the resource tags.
-        /// </summary>
-        /// <param name="tags"> The resource tags. </param>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> A <see cref="Task"/> that on completion returns the status of the delete operation. </returns>
-        Task<Response<TOperations>> SetTagsAsync(
-            IDictionary<string, string> tags,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Set the resource tags.
-        /// </summary>
-        /// <param name="tags"> The resource tags. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns>An <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for Tag completion.</returns>
-        Operation<TOperations> StartSetTags(
-            IDictionary<string, string> tags,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Set the resource tags.
-        /// </summary>
-        /// <param name="tags"> The resource tags. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns> A <see cref="Task"/> that performs the Tag operation.  The Task yields an an
-        /// <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for
-        /// Tag completion. </returns>
-        Task<Operation<TOperations>> StartSetTagsAsync(
-            IDictionary<string, string> tags,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Remove the resource tag.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> The status of the delete operation. </returns>
-        Response<TOperations> RemoveTag(
-            string key,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Remove the resource tag.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="cancellationToken"> A token allowing immediate cancellation of any blocking call performed during the deletion. </param>
-        /// <returns> A <see cref="Task"/> that on completion returns the status of the delete operation. </returns>
-        Task<Response<TOperations>> RemoveTagAsync(
-            string key,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Remove the resource tag.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns>An <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for Tag completion.</returns>
-        Operation<TOperations> StartRemoveTag(
-            string key,
-            CancellationToken cancellationToken = default);
-
-        /// <summary>
-        /// Remove the resource tag.
-        /// </summary>
-        /// <param name="key"> The tag key. </param>
-        /// <param name="cancellationToken"> A token to allow the caller to cancel the call to the service.
-        /// The default value is <see cref="CancellationToken.None" />. </param>
-        /// <returns> A <see cref="Task"/> that performs the Tag operation.  The Task yields an an
-        /// <see cref="Operation{TOperations}"/> that allows the user to control polling and waiting for
-        /// Tag completion. </returns>
-        Task<Operation<TOperations>> StartRemoveTagAsync(
-            string key,
-            CancellationToken cancellationToken = default);
-    }
-}
diff --git a/sdk/resourcemanager/Proto.Client/authorization/RoleAssignmentOperations.cs b/sdk/resourcemanager/Proto.Client/authorization/RoleAssignmentOperations.cs
index 0cabee0f165df..878a227f5a14d 100644
--- a/sdk/resourcemanager/Proto.Client/authorization/RoleAssignmentOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/authorization/RoleAssignmentOperations.cs
@@ -13,7 +13,7 @@ namespace Proto.Authorization
     /// <summary>
     /// Operations over Role Assignments for Role-based access control to ARM resources
     /// </summary>
-    public class RoleAssignmentOperations : ExtensionResourceOperationsBase<RoleAssignment>, IDeletableResource
+    public class RoleAssignmentOperations : ExtensionResourceOperationsBase<RoleAssignment>
     {
         /// <summary>
         /// Gets the resource type for Role Assignments.
diff --git a/sdk/resourcemanager/Proto.Client/compute/AvailabilitySetOperations.cs b/sdk/resourcemanager/Proto.Client/compute/AvailabilitySetOperations.cs
index 0e4fdb7f4a88b..faaf7ab3d332b 100644
--- a/sdk/resourcemanager/Proto.Client/compute/AvailabilitySetOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/compute/AvailabilitySetOperations.cs
@@ -12,7 +12,7 @@ namespace Proto.Compute
     /// <summary>
     /// A class representing the operations that can be performed over a specific availability set.
     /// </summary>
-    public class AvailabilitySetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, AvailabilitySet>, ITaggableResource<ResourceGroupResourceIdentifier, AvailabilitySet>, IDeletableResource
+    public class AvailabilitySetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, AvailabilitySet>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="GenericResourceOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/compute/VirtualMachineOperations.cs b/sdk/resourcemanager/Proto.Client/compute/VirtualMachineOperations.cs
index 5303100bc9790..71402ce7e0298 100644
--- a/sdk/resourcemanager/Proto.Client/compute/VirtualMachineOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/compute/VirtualMachineOperations.cs
@@ -12,7 +12,7 @@ namespace Proto.Compute
     /// <summary>
     /// A class representing the operations that can be performed over a specific VirtualMachine.
     /// </summary>
-    public class VirtualMachineOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualMachine>, ITaggableResource<ResourceGroupResourceIdentifier, VirtualMachine>, IDeletableResource
+    public class VirtualMachineOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualMachine>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="VirtualMachineOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/compute/VirtualMachineScaleSetOperations.cs b/sdk/resourcemanager/Proto.Client/compute/VirtualMachineScaleSetOperations.cs
index 4fca4a567b7db..9b5aec1ce870c 100644
--- a/sdk/resourcemanager/Proto.Client/compute/VirtualMachineScaleSetOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/compute/VirtualMachineScaleSetOperations.cs
@@ -12,7 +12,7 @@ namespace Proto.Compute
     /// <summary>
     /// A class representing the operations that can be performed over a specific VirtualMachineScaleSet.
     /// </summary>
-    public class VirtualMachineScaleSetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualMachineScaleSet>, ITaggableResource<ResourceGroupResourceIdentifier, VirtualMachineScaleSet>, IDeletableResource
+    public class VirtualMachineScaleSetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualMachineScaleSet>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="VirtualMachineScaleSetOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/network/LoadBalancerOperations.cs b/sdk/resourcemanager/Proto.Client/network/LoadBalancerOperations.cs
index 977c5e22a7127..ff0c6a8a2e34f 100644
--- a/sdk/resourcemanager/Proto.Client/network/LoadBalancerOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/LoadBalancerOperations.cs
@@ -10,7 +10,7 @@ namespace Proto.Network
     /// A class representing the operations that can be performed over a specific LoadBalancer.
     /// </summary>
     // TODO, ITaggable was not added.
-    public class LoadBalancerOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, LoadBalancer>, IDeletableResource
+    public class LoadBalancerOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, LoadBalancer>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="LoadBalancerOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/network/NetworkInterfaceOperations.cs b/sdk/resourcemanager/Proto.Client/network/NetworkInterfaceOperations.cs
index 7faf79a683a13..ed20ef5ac4220 100644
--- a/sdk/resourcemanager/Proto.Client/network/NetworkInterfaceOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/NetworkInterfaceOperations.cs
@@ -11,7 +11,7 @@ namespace Proto.Network
     /// <summary>
     /// A class representing the operations that can be pefroemd over a specific <see cref="NetworkInterface"/>.
     /// </summary>
-    public class NetworkInterfaceOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, NetworkInterface>, ITaggableResource<ResourceGroupResourceIdentifier,NetworkInterface>, IDeletableResource
+    public class NetworkInterfaceOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, NetworkInterface>
     {
         internal NetworkInterfaceOperations(GenericResourceOperations genericOperations)
             : base(genericOperations, genericOperations.Id)
diff --git a/sdk/resourcemanager/Proto.Client/network/NetworkSecurityGroupOperations.cs b/sdk/resourcemanager/Proto.Client/network/NetworkSecurityGroupOperations.cs
index 6fd813f145b42..b72e8d4f0c6d6 100644
--- a/sdk/resourcemanager/Proto.Client/network/NetworkSecurityGroupOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/NetworkSecurityGroupOperations.cs
@@ -15,7 +15,7 @@ namespace Proto.Network
     /// <summary>
     /// A class representing the operations that can be performed over a specific NetworkSecurityGroup.
     /// </summary>
-    public class NetworkSecurityGroupOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, NetworkSecurityGroup>, ITaggableResource<ResourceGroupResourceIdentifier, NetworkSecurityGroup>, IDeletableResource
+    public class NetworkSecurityGroupOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, NetworkSecurityGroup>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="NetworkSecurityGroupOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/network/PublicIpAddressOperations.cs b/sdk/resourcemanager/Proto.Client/network/PublicIpAddressOperations.cs
index ff004662dd5c8..ed3a8e4aebbe6 100644
--- a/sdk/resourcemanager/Proto.Client/network/PublicIpAddressOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/PublicIpAddressOperations.cs
@@ -14,7 +14,7 @@ namespace Proto.Network
     /// <summary>
     /// A class representing the operations that can be performed over a specific NetworkSecurityGroup.
     /// </summary>
-    public class PublicIpAddressOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, PublicIpAddress>, ITaggableResource<ResourceGroupResourceIdentifier, PublicIpAddress>, IDeletableResource
+    public class PublicIpAddressOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, PublicIpAddress>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="PublicIpAddressOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/network/SubnetOperations.cs b/sdk/resourcemanager/Proto.Client/network/SubnetOperations.cs
index 8c158a331fe2a..f100ac5461524 100644
--- a/sdk/resourcemanager/Proto.Client/network/SubnetOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/SubnetOperations.cs
@@ -9,7 +9,7 @@ namespace Proto.Network
     /// <summary>
     /// A class representing the operations that can be performed over a specific subnet.
     /// </summary>
-    public class SubnetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, Subnet>, IDeletableResource
+    public class SubnetOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, Subnet>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="SubnetOperations"/> class.
diff --git a/sdk/resourcemanager/Proto.Client/network/VirtualNetworkOperations.cs b/sdk/resourcemanager/Proto.Client/network/VirtualNetworkOperations.cs
index aff6409efe729..3a2de8a6f0efa 100644
--- a/sdk/resourcemanager/Proto.Client/network/VirtualNetworkOperations.cs
+++ b/sdk/resourcemanager/Proto.Client/network/VirtualNetworkOperations.cs
@@ -11,7 +11,7 @@ namespace Proto.Network
     /// <summary>
     /// A class representing the operations that can be performed over a specific virtual nerwork.
     /// </summary>
-    public class VirtualNetworkOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualNetwork>, ITaggableResource<ResourceGroupResourceIdentifier, VirtualNetwork>, IDeletableResource
+    public class VirtualNetworkOperations : ResourceOperationsBase<ResourceGroupResourceIdentifier, VirtualNetwork>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="VirtualNetworkOperations"/> class.