Remove variable blocksize #49416
Merged
Remove variable blocksize #49416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed static method to buffer part of an existing stream netstandard2.1 impl
jaschrep-msft
requested review from
amnguye,
jalauzon-msft,
nickliu-msft,
schaabs,
seanmcc-msft and
tg-msft
as code owners
|
API change check API changes are not detected in this pull request. |
amnguye
approved these changes
Apr 23, 2025
amnguye
approved these changes
Apr 24, 2025
jalauzon-msft
approved these changes
Apr 24, 2025
jaschrep-msft
added a commit
to jaschrep-msft/azure-sdk-for-net
that referenced
this pull request
May 5, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in Azure#49416.
jaschrep-msft
added a commit
to jaschrep-msft/azure-sdk-for-net
that referenced
this pull request
May 6, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in Azure#49416.
seanmcc-msft
pushed a commit
that referenced
this pull request
May 6, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in #49416.
nick863
pushed a commit
that referenced
this pull request
May 8, 2025
* CopyToExact stream extension * PooledMemoryStream changes Removed static method to buffer part of an existing stream netstandard2.1 impl * fix tests Lots of values adjusted to account for behavior change Some fixes for api changes * revert namechange * remove more plumbing of max&min counts
nick863
pushed a commit
that referenced
this pull request
May 8, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in #49416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes behavior from PartitionedUploader where if a block is at least half-filled with data, it will be uploaded as is without waiting for another stream read.
This is a behavior which produces inconsistent results and adds maintenance overhead. It has been removed.