Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add extra.branch-alias setting to composer.json #769

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Jan 24, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Add extra.branch-alias setting to composer.json in order to allow install
development versions while respecting semver.
This obviously can be updated taking into account the current branching/release
strategy, maybe the branch alias should be pointing to 0.5-dev instead of
0.4-dev.
This change allows to use constraints like "microsoft/windowsazure": "^0.4@dev", which will actually install thedev-master` version.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @phansys, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@yaqiyang
Copy link
Member

@phansys, Thanks very much for your contribution. However, I am not sure I understand your reasoning for adding this property. According to https://getcomposer.org/doc/04-schema.md#extra, this is to add extra data for the scripts property. But we don't have a scripts property here.
Also, will the data at the extra tag provide value for most users?

Thanks
Yaqi Yang

@phansys
Copy link
Contributor Author

phansys commented Mar 18, 2016

@yaqiyang, please take a look at https://getcomposer.org/doc/articles/aliases.md#branch-alias, I think it should explain the feature better than me.
Let me know if your need some clarification.
Cheers.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Add `extra.branch-alias` setting to `composer.json` in order to allow install
development versions while respecting [semver](http://semver.org/).
This obviously can be updated taking into account the current branching/release
strategy, maybe the branch alias should be pointing to `0.5-dev` instead of
`0.4-dev`.
This change allows to use constraints like `"microsoft/windowsazure": "^0.4@dev",
which will actually install the `dev-master` version.
@phansys phansys force-pushed the semver-branch-alias branch from 057401d to 93a5ffb Compare March 18, 2016 01:50
yaqiyang added a commit that referenced this pull request Mar 18, 2016
Add `extra.branch-alias` setting to `composer.json`
@yaqiyang yaqiyang merged commit 15f24e8 into Azure:master Mar 18, 2016
@phansys
Copy link
Contributor Author

phansys commented Mar 18, 2016

Thank you @yaqiyang.

@phansys phansys deleted the semver-branch-alias branch March 18, 2016 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants