Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resources post test #13379

Merged
merged 34 commits into from
Sep 1, 2020
Merged

Remove resources post test #13379

merged 34 commits into from
Sep 1, 2020

Conversation

seankane-msft
Copy link
Member

No description provided.

@seankane-msft seankane-msft added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 27, 2020
@seankane-msft seankane-msft requested a review from scbedd August 27, 2020 20:04
@seankane-msft seankane-msft self-assigned this Aug 27, 2020
@seankane-msft seankane-msft added this to the [2020] September milestone Aug 28, 2020
@seankane-msft
Copy link
Member Author

Addresses #12764

@seankane-msft
Copy link
Member Author

And #13406

@kristapratico
Copy link
Member

kristapratico commented Aug 29, 2020

The "packaging update" commit seems to have done something strange to this PR...

sdk/tables/azure-data-tables/README.md Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/setup.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/setup.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/setup.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/setup.py Outdated Show resolved Hide resolved
@seankane-msft seankane-msft force-pushed the remove-resources-post-test branch from 5f98393 to 4b39948 Compare August 31, 2020 23:25
@seankane-msft seankane-msft force-pushed the remove-resources-post-test branch from b7e06a5 to 3168551 Compare September 1, 2020 19:06
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seankane-msft seankane-msft merged commit e9bd025 into master Sep 1, 2020
@seankane-msft seankane-msft deleted the remove-resources-post-test branch September 1, 2020 21:22
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 2, 2020
…into link_om_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  Int32 serialization (Azure#13452)
  add output to opinion mining sample (Azure#13494)
  Add Document w/ Eng Sys Checks (Azure#13492)
  update version (Azure#13495)
  Remove resources post test (Azure#13379)
  bing_id -> bing_entity_search_api_id (Azure#13491)
  [EventGrid] Read me + improve docstrings (Azure#13484)
  Build AuthenticationRecords from ADFS identity tokens (Azure#13341)
  Support Subject Name/Issuer authentication (Azure#13350)
  Add KeyVaultAccessControlClient for data plane RBAC (Azure#13372)
  [text analytics] Add redacted_text (Azure#13449)
  add python sdk sample (Azure#13338)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Sep 4, 2020
* pruning tests.yml

* potential fix

* updated environment variables

* another change to tests.yml

* change

* edits to testcase

* setting storage_name and rg_kwargs to None to help identify problem

* forcing i_need_to_create_rg to be True

* flirting with version change

* reverting back to normal for both testcase and version

* Packaging update of azure-data-tables

* adding azure identity to dev reqs

* adding azure-identity to dev_reqs

* mirror updates from personal branch

* adding continue on error so we can see the env

* update shared test case rg_kwargs resource to mapping instead of NoneType

* updating dev_reqs

* random issues gone?

* build-test changes

* undoing all the bot changes from AutorestCI

* edits thanks to Kristas suggestion, hopefully stops AutorestCI from sabotage

* import directly from file, python2 can't find the module

* pylint fixes

* debugging why python 2.7 can't find azure data tables

* undoing last change

* reverting setup.py to master branch, adding space in inits just incase

* add comprehension of nspkg to azure-data-tables

* adding nspkg to shared_reqs

* updating shared_req to freeze nspkg at the same version

Co-authored-by: Azure SDK Bot <adxpysdk@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants