Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing version issue by not overwriting the version with the semantic… #13411

Merged
merged 3 commits into from
Aug 31, 2020
Merged

fixing version issue by not overwriting the version with the semantic… #13411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6786a5f
fixing version issue by not overwriting the version with the semantic…
seankane-msft Aug 28, 2020
e791d24
removed VERSION imports
seankane-msft Aug 31, 2020
e0c367e
Merge branch 'master' into version-isse
seankane-msft Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
from ._serialize import serialize_iso
from ._deserialize import _return_headers_and_deserialized
from ._error import _process_table_error
from ._version import VERSION
from ._models import TableEntityPropertiesPaged, UpdateMode
from ._models import TableEntityPropertiesPaged, UpdateMode, TableItem


class TableClient(TableClientBase):
Expand Down Expand Up @@ -59,7 +58,6 @@ def __init__(
"""
super(TableClient, self).__init__(account_url, table_name, credential=credential, **kwargs)
self._client = AzureTable(self.url, pipeline=self._pipeline)
self._client._config.version = kwargs.get('api_version', VERSION) # pylint: disable=protected-access

@classmethod
def from_connection_string(
Expand Down
2 changes: 0 additions & 2 deletions sdk/tables/azure-data-tables/azure/data/tables/_table_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from ._base_client import parse_connection_str, TransportWrapper
from ._models import LocationMode
from ._error import _process_table_error
from ._version import VERSION
from ._table_client import TableClient
from ._table_service_client_base import TableServiceClientBase

Expand Down Expand Up @@ -47,7 +46,6 @@ def __init__(

super(TableServiceClient, self).__init__(account_url, service='table', credential=credential, **kwargs)
self._client = AzureTable(self.url, pipeline=self._pipeline)
self._client._config.version = kwargs.get('api_version', VERSION) # pylint: disable=protected-access

@classmethod
def from_connection_string(
Expand Down
2 changes: 0 additions & 2 deletions sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from azure.core.tracing.decorator import distributed_trace
from azure.core.tracing.decorator_async import distributed_trace_async

from .. import VERSION
from .._base_client import parse_connection_str
from .._entity import TableEntity
from .._generated.aio import AzureTable
Expand Down Expand Up @@ -71,7 +70,6 @@ def __init__(
account_url, table_name=table_name, credential=credential, loop=loop, **kwargs
)
self._client = AzureTable(self.url, pipeline=self._pipeline, loop=loop)
self._client._config.version = kwargs.get('api_version', VERSION) # pylint: disable = W0212
self._loop = loop

@classmethod
Expand Down
3 changes: 1 addition & 2 deletions sdk/tables/azure-data-tables/azure/data/tables/aio/_table_service_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from azure.core.tracing.decorator import distributed_trace
from azure.core.tracing.decorator_async import distributed_trace_async

from .. import VERSION, LocationMode
from .. import LocationMode
from .._base_client import parse_connection_str
from .._generated.aio._azure_table_async import AzureTable
from .._generated.models import TableServiceProperties, TableProperties, QueryOptions
Expand Down Expand Up @@ -84,7 +84,6 @@ def __init__(
loop=loop,
**kwargs)
self._client = AzureTable(url=self.url, pipeline=self._pipeline, loop=loop) # type: ignore
self._client._config.version = kwargs.get('api_version', VERSION) # pylint: disable=protected-access
self._loop = loop

@classmethod
Expand Down