From 8464119b7b98fdedf37c26f668acf8d1a066c7f8 Mon Sep 17 00:00:00 2001 From: praveenkuttappan Date: Fri, 26 Feb 2021 17:08:51 -0800 Subject: [PATCH 1/4] Added more logging to API view create --- eng/common/scripts/Create-APIReview.ps1 | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 1cef3141337e..a66ba7853645 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -46,6 +46,7 @@ function Submit-APIReview($packagename, $filePath, $uri, $apiKey, $apiLabel) } catch { + Write-Error "Exception details: $($_.Exception.Response)" $StatusCode = $_.Exception.Response.StatusCode } @@ -101,6 +102,9 @@ foreach ($pkgName in $responses.Keys) { $pkgInfo = Get-Content $pkgPropPath | ConvertFrom-Json $version = [AzureEngSemanticVersion]::ParseVersionString($pkgInfo.Version) + Write-Host "Package name: $($PackageName)" + Write-Host "Version: $($version)" + Write-Host "SDK Type: $($pkgInfo.SdkType)" if ($version.IsPrerelease) { Write-Host "Package version is not GA. Ignoring API view approval status" @@ -110,11 +114,15 @@ foreach ($pkgName in $responses.Keys) $FoundFailure = $True if ($respCode -eq '201') { - Write-Error "Automatic API Review approval is pending for package $($PackageName)" + Write-Host "Package version $($version) is GA and automatic API Review is not yet approved for package $($PackageName)." + Write-Host "Build and release is not allowed for GA package without API review approval." + Write-Host "Please reach out to API review approvers and share above link to review for approval." + Write-Host "You will need to queue another build to proceed further after API review is approved" + Write-Host "You can reach out to Azure SDK engineering systems on teams channel if review is in approved status" } else { - Write-Error "Failed to create API Review for package $($PackageName)" + Write-Error "Failed to create API Review for package $($PackageName). Please reach out to Azure SDK engineering systems on teams channel and share this build details." } } else @@ -126,6 +134,6 @@ foreach ($pkgName in $responses.Keys) } if ($FoundFailure) { - Write-Error "Automatic API review is not yet approved for package $($PackageName)" + # Deailed log for each scenario is mentioned above exit 1 } From 1e30704837a191fed429496d49781f52aef6455a Mon Sep 17 00:00:00 2001 From: praveenkuttappan Date: Wed, 3 Mar 2021 14:15:40 -0800 Subject: [PATCH 2/4] Updated logs with arch board rescue email address --- eng/common/scripts/Create-APIReview.ps1 | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index a66ba7853645..3167566e8a64 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -41,7 +41,7 @@ function Submit-APIReview($packagename, $filePath, $uri, $apiKey, $apiLabel) try { $Response = Invoke-WebRequest -Method 'POST' -Uri $uri -Body $multipartContent -Headers $headers - Write-Host "API Review: $($Response)" + Write-Host "API Review URL: $($Response)" $StatusCode = $Response.StatusCode } catch @@ -116,14 +116,15 @@ foreach ($pkgName in $responses.Keys) { Write-Host "Package version $($version) is GA and automatic API Review is not yet approved for package $($PackageName)." Write-Host "Build and release is not allowed for GA package without API review approval." - Write-Host "Please reach out to API review approvers and share above link to review for approval." + Write-Host "Please send email to adparchrescue@microsoft.com and share above link to API review for emergency approval to release you package." Write-Host "You will need to queue another build to proceed further after API review is approved" - Write-Host "You can reach out to Azure SDK engineering systems on teams channel if review is in approved status" + Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details." } else { - Write-Error "Failed to create API Review for package $($PackageName). Please reach out to Azure SDK engineering systems on teams channel and share this build details." - } + Write-Error "Failed to create API Review for package $($PackageName). Please reach out to Azure SDK engineering systems on teams channel and share this build details." + } + exit 1 } else { @@ -132,8 +133,3 @@ foreach ($pkgName in $responses.Keys) } } } -if ($FoundFailure) -{ - # Deailed log for each scenario is mentioned above - exit 1 -} From 67ab047949e52b30c9d9e42eaa8dda3736543128 Mon Sep 17 00:00:00 2001 From: praveenkuttappan Date: Thu, 4 Mar 2021 01:23:58 -0800 Subject: [PATCH 3/4] Fix as per review comments --- eng/common/scripts/Create-APIReview.ps1 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 3167566e8a64..4fcf6c9cdd42 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -46,7 +46,7 @@ function Submit-APIReview($packagename, $filePath, $uri, $apiKey, $apiLabel) } catch { - Write-Error "Exception details: $($_.Exception.Response)" + Write-Host "Exception details: $($_.Exception.Response)" $StatusCode = $_.Exception.Response.StatusCode } @@ -116,13 +116,12 @@ foreach ($pkgName in $responses.Keys) { Write-Host "Package version $($version) is GA and automatic API Review is not yet approved for package $($PackageName)." Write-Host "Build and release is not allowed for GA package without API review approval." - Write-Host "Please send email to adparchrescue@microsoft.com and share above link to API review for emergency approval to release you package." Write-Host "You will need to queue another build to proceed further after API review is approved" - Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details." + Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." } else { - Write-Error "Failed to create API Review for package $($PackageName). Please reach out to Azure SDK engineering systems on teams channel and share this build details." + Write-Host "Failed to create API Review for package $($PackageName). Please reach out to Azure SDK engineering systems on teams channel and share this build details." } exit 1 } From c399e16542c20da163e03352855218b9b8325cff Mon Sep 17 00:00:00 2001 From: praveenkuttappan Date: Fri, 5 Mar 2021 02:22:45 -0800 Subject: [PATCH 4/4] Update logging to show API URL --- eng/common/scripts/Create-APIReview.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 4fcf6c9cdd42..b0ecc542ffed 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -41,7 +41,7 @@ function Submit-APIReview($packagename, $filePath, $uri, $apiKey, $apiLabel) try { $Response = Invoke-WebRequest -Method 'POST' -Uri $uri -Body $multipartContent -Headers $headers - Write-Host "API Review URL: $($Response)" + Write-Host "API Review URL: $($Response.Content)" $StatusCode = $Response.StatusCode } catch