Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo commands using package name instead of pushing into directory #1934

Open
heaths opened this issue Nov 22, 2024 · 1 comment
Open
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Nov 22, 2024

Since all our crates are in a single workspace, it's better that the pipeline commands (scripts, etc.) pass --package (short: -p) when supported because:

  1. It's easier to see what package a command was run on if there's a failure (have to hunt for the directory we pushed into otherwise most times),
  2. It's less maintenance and risk pushing into directories and popping on errors (it's rare, but I've seen the pop fail to be executed).
@heaths heaths added the EngSys This issue is impacting the engineering system. label Nov 22, 2024
@heaths
Copy link
Member Author

heaths commented Nov 22, 2024

Note that, for eng/scripts/Test-Packages.ps1, the package info should already have the package name. If anything, the manifest directory name should match the crate name, though it's best to read the crate name from the manifest if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

2 participants