Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prioritized] Add CLI verb config #4652

Closed
2 of 4 tasks
scbedd opened this issue Nov 8, 2022 · 3 comments · Fixed by #6010
Closed
2 of 4 tasks

[Prioritized] Add CLI verb config #4652

scbedd opened this issue Nov 8, 2022 · 3 comments · Fixed by #6010
Assignees
Labels
Asset-Sync Any issues relating to moving test assets out of repos.

Comments

@scbedd
Copy link
Member

scbedd commented Nov 8, 2022

In short, we want an "official" way to interact with the assets.json only involving the test-proxy and now pshell to do things like create it.

  • test-proxy config initialize (pending, I don't have a good way to discover language in an automated way
  • test-proxy config show (shows details about config, relevant paths, etc)
  • test-proxy config locate (shows location of assets repo for config file)
  • test-proxy config diff (generates a git link that diffs current and previous tags)
@scbedd scbedd added the Asset-Sync Any issues relating to moving test assets out of repos. label Nov 8, 2022
@scbedd scbedd self-assigned this Nov 8, 2022
@scbedd scbedd moved this to 🤔Triage in Azure SDK EngSys 🚢🎉 Nov 8, 2022
@benbp
Copy link
Member

benbp commented Nov 10, 2022

@scbedd For example, does this mean that test-proxy cd sdk/appconfiguration would take the user to <repo>/.assets/<path boilerplate>/appconfiguration?

The cd action/verb feels a little odd to me, especially as a top level command amongst start|push|etc.. Perhaps having a verb class for config would give you some breathing room for additional actions?

test-proxy config path # infer from current directory
cd $(test-proxy config path)
test-proxy config path sdk/appconfiguration
test-proxy config path /home/ben/sdk/azure-sdk-for-python/sdk/appconfiguration
test-proxy config edit # open in code, vim, etc. feels very extra though
test-proxy config show
test-proxy config github # open/print github link to assets tag/files
test-proxy config intialize # [EDIT ADDED] create new assets.json

@scbedd
Copy link
Member Author

scbedd commented Nov 17, 2022

I like this a lot. A lot a lot. Going to take a pause on the current PR to change to something like this.

@benbp
Copy link
Member

benbp commented Feb 3, 2023

We should also add test-proxy config initialize as a command based on discussion.

@scbedd scbedd changed the title Add CLI command that exposes test-proxy assets folder given an assets.json Add CLI verb config Feb 3, 2023
@scbedd scbedd changed the title Add CLI verb config [Prioritized] Add CLI verb config Feb 9, 2023
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Apr 20, 2023
@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Apr 21, 2023
@scbedd scbedd moved this from 🎊 Closed to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Apr 21, 2023
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset-Sync Any issues relating to moving test assets out of repos.
Projects
None yet
2 participants