From 03a3d7d173ac3684fb8204cf8b372b059218badb Mon Sep 17 00:00:00 2001 From: Scott Beddall Date: Thu, 2 Jun 2022 16:07:35 -0700 Subject: [PATCH 1/2] ensure conditions all work properly in the case of a previous error --- eng/common/pipelines/templates/steps/credscan.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/eng/common/pipelines/templates/steps/credscan.yml b/eng/common/pipelines/templates/steps/credscan.yml index 0171c79d0d2..8a2e53748ab 100644 --- a/eng/common/pipelines/templates/steps/credscan.yml +++ b/eng/common/pipelines/templates/steps/credscan.yml @@ -28,6 +28,8 @@ steps: Write-Host "##vso[task.setvariable variable=SKIP_CREDSCAN]true" } displayName: CredScan setup + condition: succeededOrFailed() + - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3 displayName: CredScan running condition: and(succeededOrFailed(), ne(variables['SKIP_CREDSCAN'], true)) From d5c20ad3fc7bcff68fa3461940c00683f88d0bf6 Mon Sep 17 00:00:00 2001 From: Scott Beddall Date: Wed, 4 Jan 2023 09:58:05 -0800 Subject: [PATCH 2/2] small adjustment to address Pauls issue with the auto signing --- tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs index c2b6deb87cc..91860d83eb7 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs @@ -123,7 +123,7 @@ public async Task Push(string pathToAssetsJson) { } SetOrigin(config); - GitHandler.Run($"tag {generatedTagName}", config); + GitHandler.Run($"tag -c tag.gpgsign=false {generatedTagName}", config); GitHandler.Run($"push origin {generatedTagName}", config); HideOrigin(config); }