Update guidelines regarding the Options parameter pattern #8224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
commented
Nov 8, 2024
| @@ -642,7 +647,7 @@ BlobBaseClient client = ... | |||
|
|
|||
| {% include requirement/MUST id="dotnet-lro-waituntil" %} take ```WaitUntil``` as the first parameter to LRO methods. | |||
|
|
|||
| {% include requirement/MUST id="dotnet-lro-waituntil" %} put methods that cannot be called until after the long-running operation has started on the subclass of ```Operation<T>```. For example, if a service provides an API to cancel an operation, the ```Cancel``` method should appear on the subclass of ```Operation```. | |||
| {% include requirement/MUST id="dotnet-lro-subclient-methods" %} put methods that cannot be called until after the long-running operation has started on the subclass of ```Operation<T>```. For example, if a service provides an API to cancel an operation, the ```Cancel``` method should appear on the subclass of ```Operation```. | |||
There was a problem hiding this comment.
This is just a correction to a prior PR, where I didn't differentiate the anchor -- not doing so prevents linking to the guideline directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.