-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Text-Generation/Chat MaaP FineTuning sample #3459
base: main
Are you sure you want to change the base?
Conversation
… sasum/maap-text-gen-sample
…/azureml-examples into sasum/maap-text-gen-sample
"source": [ | ||
"## FineTuning LLM with Model-As-Service\n", | ||
"\n", | ||
"This sample shows how use create a standalone FineTuning job to fine tune a model to summarize a dialog between 2 people using samsum dataset.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in " how use create"
"source": [ | ||
"## FineTuning LLM with Model-As-Service\n", | ||
"\n", | ||
"This sample shows how use create a standalone FineTuning job to fine tune a model to summarize a dialog between 2 people using samsum dataset.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the meaning of 'standalone' - what are the other options ?
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"### 2. Pick a foundation model to fine tune\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reference to 'foundational' in UI. What's the reason to use the term here ?
"outputs": [], | ||
"source": [ | ||
"model_name = \"Phi-3-mini-4k-instruct\"\n", | ||
"foundation_model = registry_ml_client.models.get(model_name, label=\"latest\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about just 'model' instead of 'foundation_model' ?
"outputs": [], | ||
"source": [ | ||
"model_name = \"Phi-3-mini-4k-instruct\"\n", | ||
"foundation_model = registry_ml_client.models.get(model_name, label=\"latest\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to expose a version as part of the sample? User cannot select a version in AIStudio
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"## FineTuning LLM with Model-As-Service\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong title ? Is this about MaaS or MaaP ?
To run the fine-tuning job, use the following command: | ||
|
||
```bash | ||
az ml job create --file text-generation-finetuning-amlcompute.yaml --resource-group hyperdrive-service-static-rg --workspace-name train-finetune-dev-eastus --name "ft-maap-llama3-instance-types-1209-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using instead of hardcoded values for rg, ws etc.
Description
Checklist