Show default diagnostic level in rule descriptions #13888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
approved these changes
Apr 16, 2024
|
Test this change out locally with the following install scripts (Action run 8808651224) VSCode
Azure CLI
|
|
Related to ##8013 |
| @@ -438,5 +438,18 @@ public void RuleConfigs_DefaultLevelShouldMatchRuleDefinition(string id, IBicepA | |||
| defaultLevelInSchema.Should().Be(defaultLevelInRuleDefinition, | |||
| $"the default diagnostic level of a rule's config schema should match that defined in the rule's class definition (make sure rule {id} #/definitions/rule-def-level-xxx reference is correct)"); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void RuleConfigs_RuleDescriptionShouldIndicateDefaultDiagnosticLevel() | |||
anthony-c-martin
approved these changes
Apr 22, 2024
anthony-c-martin
added a commit
that referenced
this pull request
Apr 24, 2024
#13888 and #13905 were checked in at around the same time, but contained incompatible changes causing test failures on main. This PR fixes up the test failure. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow