From 5f426a8ed8637e0b3ef5de5ddb5767960f263767 Mon Sep 17 00:00:00 2001 From: Michael Steinberg Date: Fri, 27 Jul 2018 19:05:13 -0700 Subject: [PATCH 1/3] add primary button outline --- CHANGELOG.md | 8 ++++++++ README.md | 8 ++++---- lib/components/Button/Button.scss | 2 +- package.json | 2 +- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 594fcbf..083ebf1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # CHANGELOG +## v2.0.3 +### Fixed +- add outline for primary button + +## v2.0.2 +migrating to private package registry and changing package scope. +update references to fluent css + ## v2.0.1 ### Fixed - alert close button hover colors didn't work across themes. updated to newer version of fluent-colors diff --git a/README.md b/README.md index b8b5d23..76a199f 100644 --- a/README.md +++ b/README.md @@ -23,11 +23,11 @@ contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additio ## Docs 1. npm run docs:build 2. npm run docs -3. You can now view style guide in the browser: - +3. You can now view style guide in the browser: + - `On Local:` http://localhost:6060/ - - - `On your network:` http://10.0.75.1:6060/ + + - `On your network:` http://{machine ip address}:6060/ ## Bug/ Issue diff --git a/lib/components/Button/Button.scss b/lib/components/Button/Button.scss index 2abcc48..be230ce 100644 --- a/lib/components/Button/Button.scss +++ b/lib/components/Button/Button.scss @@ -92,7 +92,7 @@ $outline-focus-border-width: 1px; &:focus:not(:disabled) { color: themed('color-text-white'); background-color: themed('color-bg-btn-primary-focus'); - outline: $outline-focus-border-width dashed themed('color-border-focus'); + outline: $outline-focus-border-width dashed themed('color-text-white'); } &:active:not(:disabled) { diff --git a/package.json b/package.json index 96e6ce2..99dd9eb 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@azure-iot/ux-fluent-controls", - "version": "2.0.2", + "version": "2.0.3", "description": "Azure IoT Fluent React Controls", "main": "./lib/index.js", "types": "./lib/index.d.ts", From 1a422837ed96771575fd55e04c8b80983b17f6e9 Mon Sep 17 00:00:00 2001 From: Michael Steinberg Date: Mon, 30 Jul 2018 11:07:16 -0700 Subject: [PATCH 2/3] move focus outline inboard 2px --- lib/components/Button/Button.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/components/Button/Button.scss b/lib/components/Button/Button.scss index be230ce..c8aebb1 100644 --- a/lib/components/Button/Button.scss +++ b/lib/components/Button/Button.scss @@ -93,6 +93,7 @@ $outline-focus-border-width: 1px; color: themed('color-text-white'); background-color: themed('color-bg-btn-primary-focus'); outline: $outline-focus-border-width dashed themed('color-text-white'); + outline-offset: -2px; } &:active:not(:disabled) { From 34b0ec30b383ba9570030b099c176f9edab71e2f Mon Sep 17 00:00:00 2001 From: Michael Steinberg Date: Mon, 30 Jul 2018 12:06:44 -0700 Subject: [PATCH 3/3] upgrade css library to get color variable --- CHANGELOG.md | 1 + lib/components/Button/Button.scss | 2 +- package.json | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 083ebf1..29d89fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## v2.0.3 ### Fixed - add outline for primary button +- upgrade fluent css version ## v2.0.2 migrating to private package registry and changing package scope. diff --git a/lib/components/Button/Button.scss b/lib/components/Button/Button.scss index c8aebb1..5ad1fc4 100644 --- a/lib/components/Button/Button.scss +++ b/lib/components/Button/Button.scss @@ -92,7 +92,7 @@ $outline-focus-border-width: 1px; &:focus:not(:disabled) { color: themed('color-text-white'); background-color: themed('color-bg-btn-primary-focus'); - outline: $outline-focus-border-width dashed themed('color-text-white'); + outline: $outline-focus-border-width dashed themed('color-outline-btn-primary-focus'); outline-offset: -2px; } diff --git a/package.json b/package.json index 99dd9eb..91d0c55 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "node": ">=8" }, "devDependencies": { - "@azure-iot/ux-fluent-css": "^3.0.0", + "@azure-iot/ux-fluent-css": "^3.0.2", "@types/chai": "^4.0.4", "@types/classnames": "^2.2.3", "@types/enzyme": "^2.8.9", @@ -81,7 +81,7 @@ "webpack-dev-server": "^2.9.4" }, "peerDependencies": { - "@azure-iot/ux-fluent-css": "^3.0.0", + "@azure-iot/ux-fluent-css": "^3.0.2", "classnames": "^2.2.5", "prop-types": "^15.6.1", "react": "16.x",