Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Support new platform API get_port_or_cage_type for RJ45 ports #11336

Merged

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jul 5, 2022

Depends on sonic-net/sonic-platform-common#288, and #11401

Why I did it

Support get_port_or_cage_type for RJ45 ports

How I did it

  1. implement the new platform API get_port_or_cage_type
  2. Fix the issue: unable to import SFP when chassis object is destructed

How to verify it

Manually test and regression test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

stephenxs added 4 commits July 4, 2022 04:25
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs requested a review from lguohan as a code owner July 5, 2022 09:58
@lgtm-com
Copy link

lgtm-com bot commented Jul 5, 2022

This pull request fixes 1 alert when merging 17c5bf2 into 4fb6cf0 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@stephenxs stephenxs requested a review from prgeor July 5, 2022 12:55
@stephenxs stephenxs changed the title Support get port or cage type for RJ45 ports [Mellanox] Support new platform API get_port_or_cage_type for RJ45 ports Jul 5, 2022
@liat-grozovik
Copy link
Collaborator

@prgeor could you please help to review?

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2022

This pull request fixes 1 alert when merging 7143b5d into e1f2516 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@liat-grozovik liat-grozovik merged commit 81600fa into sonic-net:master Jul 14, 2022
@stephenxs stephenxs deleted the support-get_port_or_cage_type branch July 14, 2022 09:34
yxieca pushed a commit that referenced this pull request Jul 28, 2022
…rts (#11336)

- Why I did it
Support get_port_or_cage_type for RJ45 ports

- How I did it
Implement the new platform API get_port_or_cage_type
Fix the issue: unable to import SFP when chassis object is destructed

- How to verify it
Manually test and regression test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
…rts (sonic-net#11336)

- Why I did it
Support get_port_or_cage_type for RJ45 ports

- How I did it
Implement the new platform API get_port_or_cage_type
Fix the issue: unable to import SFP when chassis object is destructed

- How to verify it
Manually test and regression test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants