[202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script to 5-10% by reducing calls to the 'tar append' operation Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
liat-grozovik
approved these changes
Dec 20, 2022
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Dec 20, 2022
Update sonic-utilities submodule pointer to include the following: * 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564)) * 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
8 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Dec 26, 2022
Update sonic-utilities submodule pointer to include the following: * f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit ([sonic-net#2561](sonic-net/sonic-utilities#2561)) * f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution ([sonic-net#2565](sonic-net/sonic-utilities#2565)) * 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564)) * 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-utilities
that referenced
this pull request
Jan 5, 2023
"[202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572)" "[generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565)" "[202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562)" This reverts commits e1c8243 f45dcfb 93172c4
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 5, 2023
- What I did Reverted PRs because they caused the degradation that some files are missing in show techsupport archive. - How I did it Reverts the following e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadym Hlushko vadymh@nvidia.com
What I did
Optimize the execution time of the 'show techsupport' script to 5-10%.
How I did it
The
show techsupportCLI command calls thegenerate_dumpbash script. In the script, there are a many functions that do the next scenario:This PR removes the
3 and 4 stepfrom those functions and creates a new functionsave_to_tar()which will add to.tararchive the whole directory with temporary files (which means it will not spawn atar -v -rhf ...process for each temporary file)How to verify it
Run the
time show techsupportCLI command and compare the execution time to the original script, the execution time will be decreased by 5-10%.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)