Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Documentation and description for variables. #42

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Poven795909
Copy link
Collaborator

This Pull request updates the Documentation and description for variables.

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@Poven795909 Poven795909 requested a review from didayal-msft July 1, 2024 06:35
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 1, 2024
@Poven795909 Poven795909 removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 1, 2024
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@Poven795909 Poven795909 requested a review from didayal-msft July 2, 2024 10:55
Copy link
Contributor

@didayal-msft didayal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Poven795909 Poven795909 merged commit 91272dd into Azure:main Jul 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants