Skip to content

Commit

Permalink
Fixing Onebranch signing issues (#2590)
Browse files Browse the repository at this point in the history
* Fixing pathing for signing

* Updating wildcard

* Adding file copy

* Updating signing codes

* Updating signing

* Revert "Updating signing"

This reverts commit c03d48d.

* Revert "Updating signing codes"

This reverts commit 8f3a443.

* Disabling un needed file copy

---------

Co-authored-by: trwalke <trwalke@microsoft.com>
  • Loading branch information
trwalke and trwalke authored May 10, 2024
1 parent 39329d8 commit c19f599
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
11 changes: 11 additions & 0 deletions build/template-Build-run-tests-sign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ steps:
**\bin\$(BuildConfiguration)\**\System.IdentityModel.Tokens.Jwt.dll
**\bin\$(BuildConfiguration)\**\System.IdentityModel.Tokens.Jwt.pdb
TargetFolder: '$(Build.ArtifactStagingDirectory)\ProductBinaries'
condition: and(succeeded(), eq(variables['PipelineType'], 'legacy'))

- task: securedevelopmentteam.vss-secure-development-tools.build-task-policheck.PoliCheck@2
displayName: 'Run PoliCheck'
Expand Down Expand Up @@ -164,6 +165,16 @@ steps:
search_root: '$(Build.SourcesDirectory)\artifacts'
condition: and(succeeded(), eq(variables['PipelineType'], 'onebranch'))

# Copy all packages out to staging
- task: CopyFiles@2
displayName: 'Copy Files from $(Build.SourcesDirectory) to: $(Build.ArtifactStagingDirectory)\packages'
inputs:
SourceFolder: '$(Build.SourcesDirectory)'
Contents: '**\*nupkg'
TargetFolder: '$(Build.ArtifactStagingDirectory)\packages'
flattenFolders: true
condition: and(succeeded(), eq(variables['PipelineType'], 'onebranch'))

- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
displayName: 'Component Detection'
inputs:
Expand Down
4 changes: 2 additions & 2 deletions build/template-sign-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@ steps:
inputs:
command: 'sign'
signing_profile: 'external_distribution' #CP-230012 -> https://eng.ms/docs/products/onebranch/signing/containerbuildsigning#signing-using-onebranchpipelinesigning-ado-task
files_to_sign: '${{ parameters.LibraryName }}.dll'
search_root: '$(Build.SourcesDirectory)\src'
files_to_sign: '**/${{ parameters.LibraryName }}.dll'
search_root: '$(Build.SourcesDirectory)\$(WilsonSourceDirectory)src'
condition: and(succeeded(), eq(variables['PipelineType'], 'onebranch'))

0 comments on commit c19f599

Please sign in to comment.