Skip to content

Conversation

@Robbie-Microsoft
Copy link
Contributor

@Robbie-Microsoft Robbie-Microsoft commented Jun 23, 2025

This PR introduces ImdsV2 as a Managed Identity source, and focuses on executing a network request to get metadata to be used in the rest of the flow.

@Robbie-Microsoft Robbie-Microsoft requested a review from a team as a code owner June 23, 2025 21:40
Copy link
Contributor

@neha-bhargava neha-bhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to undo the changes to public API to get the managed identity source

}

/// <inheritdoc/>
public async Task<ManagedIdentitySource> GetManagedIdentitySourceAsync()
Copy link
Contributor

@neha-bhargava neha-bhargava Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this as static as well. The method to get the source was created static so that Azure Identity can detect if managed identity is available before creating the source. Was this discussed with them?

Copy link
Contributor Author

@Robbie-Microsoft Robbie-Microsoft Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neha-bhargava, this method passes the Service Bundle through the ManagedIdentityClient's GetManagedIdentitySourceAsync method, and into ImdsV2ManagedIdentitySource, where the csr metadata probe uses things from the Service Bundle: IdType, UserAssignedId, RetryPolicyFactory, HttpManager, Logger, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gladjohn Can you confirm that this would work with Azure Identity? Did you discuss with them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought, we agreed to keep this static @Robbie-Microsoft.

Copy link
Contributor Author

@Robbie-Microsoft Robbie-Microsoft Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev experience won't change for Azure SDK. They are still creating an instance of Managed Identity Application for their tests - they will be able to call this method from the managedAidentityApplication. You, @bgavrilMS and I can discuss over chat.

@Robbie-Microsoft Robbie-Microsoft merged commit 38dbae3 into rginsburg/msiv2_feature_branch Aug 4, 2025
3 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the rginsburg/msiv2_probe branch August 4, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants