diff --git a/change/@azure-msal-node-b12e3eee-b810-4217-8578-e4d655383620.json b/change/@azure-msal-node-b12e3eee-b810-4217-8578-e4d655383620.json new file mode 100644 index 0000000000..0a51555ad0 --- /dev/null +++ b/change/@azure-msal-node-b12e3eee-b810-4217-8578-e4d655383620.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Allow POP Params for brokered requests", + "packageName": "@azure/msal-node", + "email": "thomas.norling@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/lib/msal-node/apiReview/msal-node.api.md b/lib/msal-node/apiReview/msal-node.api.md index 4f8f586923..0cbbf3f196 100644 --- a/lib/msal-node/apiReview/msal-node.api.md +++ b/lib/msal-node/apiReview/msal-node.api.md @@ -351,7 +351,7 @@ export { InteractionRequiredAuthErrorCodes } export { InteractionRequiredAuthErrorMessage } // @public -export type InteractiveRequest = Pick & { +export type InteractiveRequest = Partial> & { openBrowser: (url: string) => Promise; scopes?: Array; successTemplate?: string; @@ -692,7 +692,7 @@ export type SignOutRequest = { }; // @public -export type SilentFlowRequest = Partial> & { +export type SilentFlowRequest = Partial> & { account: AccountInfo; scopes: Array; }; diff --git a/lib/msal-node/src/request/InteractiveRequest.ts b/lib/msal-node/src/request/InteractiveRequest.ts index 46a8f5d5d5..d78e8a89cc 100644 --- a/lib/msal-node/src/request/InteractiveRequest.ts +++ b/lib/msal-node/src/request/InteractiveRequest.ts @@ -3,8 +3,8 @@ * Licensed under the MIT License. */ +import { CommonAuthorizationUrlRequest } from "@azure/msal-common/node"; import { ILoopbackClient } from "../network/ILoopbackClient.js"; -import { AuthorizationUrlRequest } from "./AuthorizationUrlRequest.js"; /** * Request object passed by user to configure acquireTokenInteractive API @@ -17,18 +17,11 @@ import { AuthorizationUrlRequest } from "./AuthorizationUrlRequest.js"; * - loopbackClient - Custom implementation for a loopback server to listen for authorization code response. * @public */ -export type InteractiveRequest = Pick< - AuthorizationUrlRequest, - | "authority" - | "correlationId" - | "claims" - | "azureCloudOptions" - | "account" - | "extraQueryParameters" - | "tokenQueryParameters" - | "extraScopesToConsent" - | "loginHint" - | "prompt" +export type InteractiveRequest = Partial< + Omit< + CommonAuthorizationUrlRequest, + "scopes" | "redirectUri" | "requestedClaimsHash" | "storeInCache" + > > & { openBrowser: (url: string) => Promise; scopes?: Array; diff --git a/lib/msal-node/src/request/SilentFlowRequest.ts b/lib/msal-node/src/request/SilentFlowRequest.ts index 9ab04a5bb9..aef948cfd6 100644 --- a/lib/msal-node/src/request/SilentFlowRequest.ts +++ b/lib/msal-node/src/request/SilentFlowRequest.ts @@ -19,12 +19,7 @@ import { AccountInfo, CommonSilentFlowRequest } from "@azure/msal-common/node"; export type SilentFlowRequest = Partial< Omit< CommonSilentFlowRequest, - | "account" - | "scopes" - | "resourceRequestMethod" - | "resourceRequestUri" - | "requestedClaimsHash" - | "storeInCache" + "account" | "scopes" | "requestedClaimsHash" | "storeInCache" > > & { account: AccountInfo;